Suggest ENTROPY_DATA_HOST on failed business definition IRI lookups#1333
Open
simonharrer wants to merge 1 commit into
Open
Suggest ENTROPY_DATA_HOST on failed business definition IRI lookups#1333simonharrer wants to merge 1 commit into
simonharrer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a business definition reference is an IRI whose host does not match the configured entropy-data host, the
/api/semanticslookup often fails with a 401/403 (or a missing API key). Previously the error pointed only at the API key, leaving users to guess that the host was actually wrong.This change surfaces a copy-pasteable
ENTROPY_DATA_HOST=...hint — derived from the IRI's own host — on these failures:/api/semanticsChanges
_build_requestnow also returns an optional host hint for the off-host IRI case._host_mismatch_hintbuilds the actionable, copy-pasteable suggestion._definition_resolution_erroraccepts ahintappended to the error message.Testing
test_semantics_iri_403_suggests_setting_hostand extended the missing-API-key test to assert the host hint.pytest tests/test_resolve_definitions.py— 23 passed.