Feat/hana engine#1332
Open
ToniLippmann wants to merge 3 commits into
Open
Conversation
- Remove `hana` from `[all]` and `[dev]` meta-extras: hdbcli is distributed under SAP's proprietary license (SAP Developer License), not an OSI-approved open-source license, so bundling it into the default all-inclusive extra is inappropriate. Users must opt in explicitly with `pip install datacontract-cli[hana]`. - Add SAP HANA Cloud / SAP Datasphere section to README (install table row, example YAML for HANA Cloud and Datasphere, TLS / Datasphere view notes, env-var reference table with license warning). - Add Unreleased CHANGELOG entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ToniLippmann
force-pushed
the
feat/hana-engine
branch
from
37cbd5a to
ed3a54e
Compare
Contributor
|
Only works with ODCS 3.2, as we are adding hana as a server type |
`data_contract_checks` was removed in v1.0.0. Map the two functions to their new locations: - `_retention_value_to_seconds` → engines/checks/create_checks.py - `to_sodacl_threshold` → export/sodacl_check_builder.py Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RFC-0045: SAP HANA server type.
Adds a new
hanaserver type for testing data contracts againstSAP HANA Cloud and SAP Datasphere (Open SQL schemas).
hdbcli(SAP HANA Client) — bypasses the Ibis/sqlglotpath because neither supports SAP HANA
host,port,schema;credentials via
DATACONTRACT_HANA_*env vars)primaryKey/uniqueat the data level(
COUNT(DISTINCT ...)) because Open SQL objects are predominantly viewswith no catalog constraint metadata
[hana]is an opt-in extra only —hdbcliis distributed under SAP'sproprietary license (SAP Developer License) and is therefore intentionally
excluded from
[all]Test results
Unit tests (mocked
hdbcli, no live instance required):test_hana_connection.py— passedtest_hana_schema_check.py— passedtest_hana_quality_check.py— passedtest_hana_type_mapping.py— passedtest_test_hana.py::test_hana_test_flow_bypasses_soda— passedIntegration tests (SAP Datasphere demo tenant):
test_hana_full_contract_pass— passedtest_hana_full_contract_fail_schema— passedtest_hana_quality_check_live— passed