Skip to content

Dataweaver starter folder#347

Merged
beets merged 3 commits into
datacommonsorg:masterfrom
beets:dataweaver
May 14, 2026
Merged

Dataweaver starter folder#347
beets merged 3 commits into
datacommonsorg:masterfrom
beets:dataweaver

Conversation

@beets
Copy link
Copy Markdown
Contributor

@beets beets commented May 13, 2026

Add more controls to the repo to prevent sprawl.

beets added 2 commits May 13, 2026 16:28
Restrict top-level folders to org owners to limit new folder creation
@beets beets requested a review from dhotchkiss May 13, 2026 23:40
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a CODEOWNERS file to manage repository ownership and a placeholder README.md for the Data Weaver experiment. Feedback suggests including global owners in the specific directory pattern to ensure oversight and expanding the documentation to include a project description and goals.

Comment thread CODEOWNERS
* @datacommonsorg/owners

# Data Weaver stand-alone app.
dataweaver/ @beets @nick-nlb @miss-o-soup
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In GitHub CODEOWNERS, the last matching pattern takes precedence. By defining dataweaver/ here, the global owners (@datacommonsorg/owners) defined on line 5 will be excluded from review requests for this directory. Given the goal of adding controls to 'prevent sprawl', consider including the global owners team here to maintain oversight. Additionally, per the guidance on line 2, consider using a team handle instead of individual users if one is available for this project.

dataweaver/ @datacommonsorg/owners @beets @nick-nlb @miss-o-soup

Comment thread dataweaver/README.md
@@ -0,0 +1 @@
# Data Weaver Experiment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The README is currently very sparse. To provide better context and help manage the 'sprawl' mentioned in the PR description, please include a brief description of the project's purpose, its current status as an experiment, and its scope.

Suggested change
# Data Weaver Experiment
# Data Weaver Experiment
## Description
[Add a brief description of the experiment and its goals.]

@beets beets requested a review from dwnoble May 14, 2026 15:12
@beets beets merged commit 1b35ef0 into datacommonsorg:master May 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants