Skip to content

Define segmentation when it is first mentioned#364

Merged
K-Meech merged 3 commits intodatacarpentry:mainfrom
jni:define-segmentation
Apr 28, 2026
Merged

Define segmentation when it is first mentioned#364
K-Meech merged 3 commits intodatacarpentry:mainfrom
jni:define-segmentation

Conversation

@jni
Copy link
Copy Markdown
Contributor

@jni jni commented Apr 19, 2026

While reading this lesson, I noticed that segmentation was used but not clearly defined.
I think a simple definition will help learners understand what they are working towards.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-364

The following changes were observed in the rendered markdown documents:

 07-thresholding.md | 4 +++-
 md5sum.txt         | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-04-27 22:25:44 +0000

Copy link
Copy Markdown
Contributor

@K-Meech K-Meech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jni ! I agree - a clearer definition of segmentation would be great to start this lesson.

I've made some very minor suggestions on wording below. @marcodallavecchia / @uschille - would be good if you could also take a quick look.

Comment thread episodes/07-thresholding.md Outdated
where we change the pixels of an image to make the image easier to analyze.
which is the partitioning of an image into disjoint regions, or *segments*.
The different segments can then be analyzed separately.
In thresholding, we convert an image from colour or grayscale into
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to add a blank line above 'In thresholding...' to start a new paragraph. Makes this section easier to read in the rendered docs.

@marcodallavecchia
Copy link
Copy Markdown
Contributor

thanks for the contribution @jni!

I agree with @K-Meech that the definition would fit well in the beginning of the lesson (and I cannot believe we didn't have one so far).

@K-Meech I agree with both of your suggestions, for me you can proceed with applying the suggestions and accept the PR.

@K-Meech
Copy link
Copy Markdown
Contributor

K-Meech commented Apr 24, 2026

Great! @jni - are you happy to make the small changes suggested above? Then we can get this merged 😄

Copy link
Copy Markdown
Contributor

@uschille uschille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jni for this contribution. I agree with @K-Meech's suggestions.

Comment thread episodes/07-thresholding.md
jni and others added 2 commits April 27, 2026 23:59
Uses simpler language for learners.

Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Start a new paragraph when talking about thresholding.

Co-authored-by: Ulf Schiller <uschille@users.noreply.github.com>
@jni
Copy link
Copy Markdown
Contributor Author

jni commented Apr 27, 2026

Thanks all! Yes, good suggestions. It seems this is ready to go then! 🙏

Copy link
Copy Markdown
Contributor

@uschille uschille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jni - looks good to me 👍

github-actions Bot pushed a commit that referenced this pull request Apr 27, 2026
@K-Meech K-Meech merged commit 90b5bfb into datacarpentry:main Apr 28, 2026
5 checks passed
github-actions Bot pushed a commit that referenced this pull request Apr 28, 2026
Auto-generated via `{sandpaper}`
Source  : 90b5bfb
Branch  : main
Author  : Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Time    : 2026-04-28 08:33:56 +0000
Message : Merge pull request #364 from jni/define-segmentation

Define segmentation when it is first mentioned
github-actions Bot pushed a commit that referenced this pull request Apr 28, 2026
Auto-generated via `{sandpaper}`
Source  : 53ec159
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-04-28 08:35:57 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 90b5bfb
Branch  : main
Author  : Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Time    : 2026-04-28 08:33:56 +0000
Message : Merge pull request #364 from jni/define-segmentation

Define segmentation when it is first mentioned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants