Skip to content

Correctly resolve relative includes in databricks.yml from parent folders#1870

Open
misha-db wants to merge 6 commits into
mainfrom
databricks-yml-include-section
Open

Correctly resolve relative includes in databricks.yml from parent folders#1870
misha-db wants to merge 6 commits into
mainfrom
databricks-yml-include-section

Conversation

@misha-db

Copy link
Copy Markdown
Contributor

Changes

Correctly resolve relative includes in databricks.yml from parent folders

Closes: #1818
Closes: #1731

Tests

Unit tests in BundleFileSet.test.ts

@misha-db misha-db requested a review from ilia-db March 30, 2026 08:41
@misha-db misha-db marked this pull request as ready for review March 30, 2026 08:41
return bundle.include;
}

async getIncludedFilesGlob() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used anywhere now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used, removed

@misha-db misha-db temporarily deployed to test-trigger-is April 17, 2026 13:04 — with GitHub Actions Inactive
@misha-db misha-db requested a review from ilia-db April 17, 2026 13:05
@ranasalalali

ranasalalali commented May 17, 2026

Copy link
Copy Markdown

Friendly nudge on this one — this fix for relative includes in databricks.yml from parent folders would be really useful. It looks like Linux is passing, Windows is failing, and integration tests may need the manual trigger. If someone from the team can take a look or help get the remaining checks unstuck, that’d be appreciated.

@mjestertea

Copy link
Copy Markdown

Hello

This addition would be a great to fix an issue with the functionality for many of the bundles

Thank you!

@misha-db misha-db requested a review from anton-107 June 23, 2026 14:09
@misha-db misha-db temporarily deployed to test-trigger-is June 23, 2026 14:09 — with GitHub Actions Inactive
@misha-db misha-db requested a review from rugpanov June 23, 2026 14:09
@github-actions

Copy link
Copy Markdown
Contributor

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/vscode

Inputs:

  • PR number: 1870
  • Commit SHA: 9555629616d5c496aa29f97297f153d4e3b58108

Checks will be approved automatically on success.

@rugpanov

Copy link
Copy Markdown
Contributor

The PR fixes initial include resolution in BundleFileSet, but the extension's live refresh path still depends on BundleWatcher. So after startup or after touching databricks.yml, parent-folder includes can be merged correctly, but edits to those parent include files themselves won't be observed because BundleWatcher only watches under the active project root.

Detailed finding: parent-directory includes are now returned by BundleFileSet.getIncludedFiles() (BundleFileSet.ts:103-120), but BundleWatcher still only watches YAML files under activeProjectUri (BundleWatcher.ts:36-42). For the issue’s layout, folder/sub-folder/databricks.yml includes ../../dab/databricks-shared.yml; that shared file is outside activeProjectUri, so edits/creates/deletes there won’t fire yamlFileChangeHandler, won’t invalidate bundleDataCache, and won’t refresh targets/prevalidation state until the user reloads or touches the root bundle file. If this PR is adding support for parent-folder includes, the watcher should also cover those resolved include paths, or otherwise refresh from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants