fix: repoint flatbuffers lockfile URLs to registry.npmjs.org#436
Merged
Conversation
Two flatbuffers entries resolved to npm-proxy.dev.databricks.com, a dev-only proxy unreachable from the protected release/CI runners. npm rewrites registry.npmjs.org hosts to the configured JFrog db-npm registry but leaves other hosts as-is, so 'npm clean-install' in the release build died with ECONNRESET fetching flatbuffers. Repoint to registry.npmjs.org (integrity unchanged — same tarball). Fixes the release build for RC and GA alike. Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two
flatbuffersentries inpackage-lock.jsonhadresolvedURLs pointing atnpm-proxy.dev.databricks.com(a dev-only proxy). The protected release/CI runners can't reach it, and npm only rewritesregistry.npmjs.orghosts to the configured JFrogdb-npmregistry — sonpm clean-installin the releasebuildjob failed withECONNRESET.Repoint both to
registry.npmjs.org. Integrity is content-addressed (same tarball), so only the host changes. Diff is exactly 2 lines.Why now
Caught by a dry-run of the RC release (
1.16.0-rc.1) off the pipeline branch — thebuildjob died on this before reaching publish. It would equally break the next GA release, so it's worth fixing onmainregardless of the RC.This pull request and its description were written by Isaac.