AIR CLI Integration: collapse air get run back to air get JOB_RUN_ID#5685
Open
riddhibhagwat-db wants to merge 3 commits into
Open
AIR CLI Integration: collapse air get run back to air get JOB_RUN_ID#5685riddhibhagwat-db wants to merge 3 commits into
air get run back to air get JOB_RUN_ID#5685riddhibhagwat-db wants to merge 3 commits into
Conversation
Replace the plain text view of `air get run <id>` with a one-shot, styled terminal renderer built on lipgloss + termenv: - Configuration box: the resolved run config YAML (inline params, downloaded params file, or synthesized), colorized line by line. - Metadata box: Run ID, Status, Submitted, Retries, Max Retries, Duration, Experiment, MLflow Run, User, Accelerators, Environment, with OSC 8 hyperlinks on Run ID and MLflow Run. Boxes share a light-purple border/title, warm Oat neutrals, and a restrained accent palette. Honors --no-color / NO_COLOR / non-TTY via termenv.Ascii; links degrade to the bare label (URLs stay in -o json). Sweep (foreach) runs and JSON output are unchanged. termenv becomes a direct dependency (annotated in go.mod and NOTICE). Co-authored-by: Isaac
Remove the `get` parent group and its `run` subcommand; the run-status logic is once again the `get` command itself, invoked as `air get JOB_RUN_ID`. The output (styled boxes, JOB_RUN_ID naming, Job Link, etc.) is unchanged. Co-authored-by: Isaac
riddhibhagwat-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
riddhibhagwat-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Approval status: pending
|
riddhibhagwat-db
changed the title
air get run back to air get JOB_RUN_IDair get run back to air get JOB_RUN_ID
Collaborator
Integration test reportCommit: e79f7fa
20 interesting tests: 13 SKIP, 7 RECOVERED
Top 25 slowest tests (at least 2 minutes):
|
riddhibhagwat-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
riddhibhagwat-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| @@ -125,19 +125,6 @@ func renderRunText(ctx context.Context, out io.Writer, w *databricks.WorkspaceCl | |||
| // A single write: a blank line before the first box and after the last, and | |||
| // one between each box. | |||
| fmt.Fprintf(out, "\n%s\n\n", strings.Join(sections, "\n\n")) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We decided to cut the
get runsub-resource. The run-status command is now justair get <id>— flat, with norunsubcommand.Changes
getparent group and itsrunsubcommand;newGetCommandis the run-status command itself (Use: "get JOB_RUN_ID",ExactArgs(1)).JOB_RUN_IDnaming,Job Linkheader, status table, and sweep view are all unchanged.experimental/air/getandexperimental/air/helpacceptance outputs; updated doc comments and tests that referencedair get run.Tests
TestGetCommandShape: assertsUse == "get JOB_RUN_ID", no registered subcommands, and exactly one arg required.getunit tests (invalid id, not-found text/JSON, templates,buildGetData) to the new entry point.experimental/air/{get,help}acceptance regenerated; full air unit + acceptance suites pass.This pull request and its description were written by Isaac.