-
Notifications
You must be signed in to change notification settings - Fork 55
fix(sdk): ban rate-limited node for Envoy-advertised reset window #3951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Claudius-Maginificent
wants to merge
16
commits into
v3.1-dev
Choose a base branch
from
fix/rs-dapi-client-rate-limit-rotate
base: v3.1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
72b6f6b
fix(rs-dapi-client): rotate instead of ban on ResourceExhausted rate-…
lklimek fadedd4
Merge branch 'v3.1-dev' into fix/rs-dapi-client-rate-limit-rotate
lklimek 396865f
fix(rs-dapi-client): exclude throttled node + backoff/jitter on rate-…
lklimek b8a8c32
fix(rs-dapi-client): clamp rate-limit backoff shift + symmetric invar…
lklimek 8a41c92
fix(rs-dapi-client): replace rotate-on-rate-limit with Envoy-driven b…
lklimek c905b16
refactor(rs-dapi-client): drive rate-limit ban from Envoy reset heade…
lklimek dade457
test(rs-dapi-client): apply QA-001..005 doc-accuracy and test-honesty…
lklimek 2c76a14
Merge branch 'v3.1-dev' into fix/rs-dapi-client-rate-limit-rotate
lklimek 47f4160
fix(rs-dapi-client): apply PR-3951 review fixes — ban_for max-semanti…
lklimek be6ae84
test(rs-dapi-client): restore genuine window-expiry coverage in ban_f…
lklimek 41cc076
docs(rs-dapi-client): QA-006/007/008 — ban_with_reason scope note + n…
lklimek ddfe16c
docs(rs-dapi-client): tighten ban_for/ban_with_reason scope docs; har…
lklimek caa025e
feat(dashmate): add platform.gateway.rateLimiter.responseHeaders.enab…
lklimek c49adb2
fix(dashmate): key responseHeaders migration at 4.0.0 not released rc.2
lklimek 458a28e
test(rs-dapi-client): prove ban_for via DapiClient::execute end-to-en…
lklimek b23008e
fix(dashmate): key responseHeaders migration at next release 4.0.0-rc…
lklimek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Existing 4.0.0-rc.2 configs break: required responseHeaders is queued behind a 4.0.0-rc.3 migration but package.json is still rc.2
This commit re-keys the responseHeaders backfill from
4.0.0to4.0.0-rc.3, butpackages/dashmate/package.jsonstill reports4.0.0-rc.2.ConfigFileJsonRepository.read()callsmigrateConfigFile(configFileData, configFileData.configFormatVersion, version)withversionread from package.json;migrateConfigFileFactoryearly-returns atfromVersion === toVersion(packages/dashmate/src/config/configFile/migrateConfigFileFactory.js:12-14). So for an operator already on rc.2, fromVersion === toVersion ===4.0.0-rc.2and the new migration never runs.Meanwhile this PR makes
responseHeadersa required field of the rate-limiter schema (packages/dashmate/src/config/configJsonSchema.js:705,708), and the per-config schema is enforced bynew Config(name, opts, skipValidation)insideConfigFileJsonRepository.read(). The result: any existing rc.2 deployment that pulls this PR before package.json bumps to rc.3 fails AJV validation on read with a missingresponseHeaderserror, even though the migration that would have backfilled it is sitting one version ahead.The comment correctly documents the design intent ("runs once the package bumps to rc.3"), so the change is internally consistent — but the coupling to the rc.3 version bump must land in the same PR. Either bump
packages/dashmate/package.jsonto4.0.0-rc.3in this PR, or temporarily dropresponseHeadersfrom the schemarequiredlist so existing rc.2 configs still validate until the migration can run.source: ['claude', 'codex']