Skip to content

chore(swift-sdk): correctly refer to the swift sdk as swift in the build script and cargo profiles #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZocoLini wants to merge 1 commit into
base: v3.1-dev
Choose a base branch
from
Open

chore(swift-sdk): correctly refer to the swift sdk as swift in the build script and cargo profiles #3949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/skills/simulator-control/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ If `idb connect` succeeds but `idb ui describe-all` returns a single root elemen

### Install the latest build before driving the UI

The skill assumes the binary on the simulator is current. It's not, if you've built but forgotten to install. After every `./build_ios.sh --target sim` (or any code change), push the fresh artifact:
The skill assumes the binary on the simulator is current. It's not, if you've built but forgotten to install. After every `./build_swift.sh --target sim` (or any code change), push the fresh artifact:

```bash
BUNDLE=org.dashfoundation.SwiftExampleApp
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/swift-example-app-ui-smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:

- name: Build simulator DashSDKFFI.xcframework
run: |
bash packages/swift-sdk/build_ios.sh --target sim --profile dev
bash packages/swift-sdk/build_swift.sh --target sim --profile dev

- name: Create disposable iOS simulator
id: simulator
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/swift-sdk-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:

- name: Build DashSDKFFI.xcframework and install into Swift package
run: |
bash packages/swift-sdk/build_ios.sh --target all --profile release
bash packages/swift-sdk/build_swift.sh --target all --profile release
Comment thread
coderabbitai[bot] marked this conversation as resolved.

- name: Zip XCFramework and compute checksum
id: zip
Expand Down
14 changes: 7 additions & 7 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,20 @@ dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "5c0113

tokio-metrics = "0.5"

# Size-tuned profile for the iOS `rs-unified-sdk-ffi` staticlib, which
# otherwise ships huge. Inherits `release` and is ONLY used by the iOS
# build (`build_ios.sh --profile release`)
[profile.release-ios]
# Size-tuned profile for the iOS `rs-unified-sdk-ffi` staticlibs, which
# otherwise ships huge. Inherits `release` and is ONLY used by the Swift
# build (`build_swift.sh --profile release`)
[profile.release-swift]
inherits = "release"
panic = "abort"
strip = "symbols"
lto = "fat"
codegen-units = 1
opt-level = 3

# Debug counterpart for smaller iOS dev builds. Inherits the standard `dev`
# profile (and is ONLY used by the iOS build (`build_ios.sh --profile dev`)
[profile.dev-ios]
# Debug counterpart for smaller Swift dev builds. Inherits the standard `dev`
# profile (and is ONLY used by the Swift build (`build_swift.sh --profile dev`)
[profile.dev-swift]
inherits = "dev"
panic = "abort"
lto = "thin"
Expand Down
2 changes: 1 addition & 1 deletion packages/rs-platform-wallet-ffi/IMPLEMENTATION_SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ All Week 1-8 tasks have been completed without stubs.
- Core types: Handle, IdentifierBytes, NetworkType, BlockTime, etc.

**Build System:**
- Integrated into existing `swift-sdk/build_ios.sh`
- Integrated into existing `swift-sdk/build_swift.sh`
- No standalone build script needed
- Compiles cleanly with unified xcframework

Expand Down
8 changes: 4 additions & 4 deletions packages/swift-sdk/build_ios.sh → packages/swift-sdk/build_swift.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ if ! $BUILD_IOS && ! $BUILD_SIM && ! $BUILD_MAC && ! $BUILD_INTEL_MAC; then
show_help
fi

# Map the requested base profile (dev|release) onto its iOS-tuned custom
# profile by appending "-ios" (dev-ios / release-ios)
PROFILE="${PROFILE}-ios"
# Map the requested base profile (dev|release) onto its swift-tuned custom

@shumkov shumkov Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this one to scripts as well.

@ZocoLini ZocoLini Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that needs to be a different PR, its out of the scope of this one

# profile by appending "-swift" (dev-swift / release-swift)
PROFILE="${PROFILE}-swift"
OUTPUT_DIR="$PROFILE"

log_info "Package: $PACKAGE"
Expand Down Expand Up @@ -196,7 +196,7 @@ EOF
# the bundled SDK exposes the platform-wallet shielded FFI.
CARGO_FEATURES="shielded"

if [ "$PROFILE" = "dev-ios" ]; then
if [ "$PROFILE" = "dev-swift" ]; then
CARGO_FEATURES="$CARGO_FEATURES tokio-metrics"
log_info " → tokio-metrics enabled (dev profile)"
fi
Expand Down
2 changes: 1 addition & 1 deletion packages/swift-sdk/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if [ -z "$SIM_NAME" ]; then
exit 1
fi

bash build_ios.sh --target all --profile dev
bash build_swift.sh --target all --profile dev

swift package clean
swift build
Expand Down
Loading