Skip to content

DAOS-18860 control: calc engine mem_size only on tgt count (#18407)#18443

Open
tanabarr wants to merge 2 commits into
release/2.8from
tanabarr/control-engine-memsize-mdonssd-fix-rel2_8
Open

DAOS-18860 control: calc engine mem_size only on tgt count (#18407)#18443
tanabarr wants to merge 2 commits into
release/2.8from
tanabarr/control-engine-memsize-mdonssd-fix-rel2_8

Conversation

@tanabarr

@tanabarr tanabarr commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pass memory size calculation to engine based on a 1gib/tgt quota
despite control-plane hugepage allocations taking MD-on-SSD
System-XStream into account when calculating.

Reorganize test cases in server_utils_test.go by splitting error
scenarios into a dedicated test function.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@tanabarr
DAOS-18860 control: calc engine mem_size only on tgt count (#18407)
27a9512 
Pass memory size calculation to engine based on a 1gib/tgt quota
despite control-plane hugepage allocations taking MD-on-SSD
System-XStream into account when calculating.

Reorganize test cases in server_utils_test.go by splitting error
scenarios into a dedicated test function.

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr requested review from a team as code owners June 5, 2026 12:19
@tanabarr tanabarr self-assigned this Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Ticket title is 'rebuild/no_cap.py:RbldNoCapacity.test_rebuild_no_capacity - Failed to start servers after format'
Status is 'Awaiting backport'
Labels: 'ci_2.8_daily,daily_test,request_for_2.8'
https://daosio.atlassian.net/browse/DAOS-18860

@tanabarr tanabarr requested review from kjacque, knard38 and mjmac June 5, 2026 12:19
@knard38 knard38 added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 5, 2026
knard38
knard38 previously approved these changes Jun 5, 2026
View reviewed changes
@daosbuild3

daosbuild3 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18443/1/testReport/

kjacque
kjacque previously approved these changes Jun 6, 2026
View reviewed changes
@daosbuild3

daosbuild3 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18443/1/testReport/

@tanabarr
fix unit test
42514ec 
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr dismissed stale reviews from kjacque and knard38 via 42514ec June 6, 2026 22:52
@daosbuild3

daosbuild3 commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18443/3/testReport/

@daosbuild3

daosbuild3 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18443/3/testReport/

@daosbuild3

daosbuild3 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18443/3/execution/node/1225/log

@tanabarr tanabarr requested review from kjacque and knard38 June 9, 2026 09:27
@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 9, 2026
@tanabarr

tanabarr commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

CI known failures:

@tanabarr tanabarr requested a review from a team June 9, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

@kjacque kjacque Awaiting requested review from kjacque

Assignees

@tanabarr tanabarr

Labels

clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tanabarr @daosbuild3 @kjacque @knard38