Skip to content

DAOS-18793 cq: Add mapping for cmocka -> ftest tags (#17975)#18429

Open
daltonbohning wants to merge 1 commit into
release/2.8from
dbohning/daos-18793-2.8
Open

DAOS-18793 cq: Add mapping for cmocka -> ftest tags (#17975)#18429
daltonbohning wants to merge 1 commit into
release/2.8from
dbohning/daos-18793-2.8

Conversation

@daltonbohning
Copy link
Copy Markdown
Contributor

@daltonbohning daltonbohning commented Jun 3, 2026

  • Map cmocka test files to corresponding ftest tags so the tests are automatically ran by default.
  • Skip unit tests for cmocka-only changes.
  • refactor gen_commit_pragma stop_on_match handling Handle stop_on_match at the path-level in addition to individual pragma-level.

Also includes #18163

  • Do not default stop_on_match to False since the nested default will always override the higher-level value.

Doc-only: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@daltonbohning
DAOS-18793 cq: Add mapping for cmocka -> ftest tags (#17975)
7fcaae1 
- Map cmocka test files to corresponding ftest tags so the tests are
  automatically ran by default.
- Skip unit tests for cmocka-only changes.
- refactor gen_commit_pragma stop_on_match handling
  Handle stop_on_match at the path-level in addition to individual
  pragma-level.

Also includes #18163
- Do not default stop_on_match to False since the nested default will always override the higher-level value.

Doc-only: true

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
@daltonbohning daltonbohning self-assigned this Jun 3, 2026
@daltonbohning daltonbohning added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Jun 3, 2026
daltonbohning
daltonbohning commented Jun 3, 2026
View reviewed changes
Comment thread ci/commit_pragma_mapping.yaml
Comment on lines +88 to +90
src/tests/suite/daos_inc_reint.c:
test-tag: test_daos_inc_reint_cont_recov
<<: *ftest-only
Copy link
Copy Markdown
Contributor Author

@daltonbohning daltonbohning Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclean because src/tests/ftest/rebuild/inc_reint.py does not exist in release/2.8 but I left this just in case it gets backported.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Ticket title is 'ftest: add mapping for cmocka tests to ftest tags'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-18793

@github-actions github-actions Bot added the priority Ticket has high priority (automatically managed) label Jun 3, 2026
@daltonbohning daltonbohning marked this pull request as ready for review June 5, 2026 16:27
@daltonbohning daltonbohning requested a review from phender June 5, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phender phender Awaiting requested review from phender

At least 1 approving review is required to merge this pull request.

Assignees

@daltonbohning daltonbohning

Labels

priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@daltonbohning