Skip to content

Version Packages#708

Merged
orionmiz merged 1 commit intomainfrom
changeset-release/main
Apr 30, 2026
Merged

Version Packages#708
orionmiz merged 1 commit intomainfrom
changeset-release/main

Conversation

@daangnbot
Copy link
Copy Markdown
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@stackflow/plugin-history-sync@1.10.1

Patch Changes

  • 2c5786a: Fix fallbackActivity callback being invoked on every initialization regardless of route matching outcome. Restored the pre-1.8.0 contract: the callback is now called only when no route matches currentPath. Apps that perform side effects in this callback (e.g. Sentry logging for unknown deep links) no longer fire on successful matches.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying stackflow-demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 739e079
Status:⚡️  Build in progress...

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 30, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stackflow-docs 739e079 Commit Preview URL Apr 30 2026, 09:45 AM

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1aa7861d-49ac-4102-84fd-939d9deaedd4

📥 Commits

Reviewing files that changed from the base of the PR and between 2c5786a and 739e079.

📒 Files selected for processing (4)
  • .changeset/fix-fallback-activity-called-on-match.md
  • docs/components/ChangelogContent.mdx
  • extensions/plugin-history-sync/CHANGELOG.md
  • extensions/plugin-history-sync/package.json
💤 Files with no reviewable changes (1)
  • .changeset/fix-fallback-activity-called-on-match.md

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Fixed callback behavior to only trigger when route matching fails, preventing unnecessary side effects during successful route matches.
  • Documentation

    • Updated changelog entries for version 1.10.1 release.

Walkthrough

This PR documents and releases version 1.10.1 of @stackflow/plugin-history-sync with a patch fix where the fallbackActivity callback no longer executes during initialization for successful route matches; it only triggers when route matching fails.

Changes

Cohort / File(s) Summary
Changelog and Version Documentation
docs/components/ChangelogContent.mdx, extensions/plugin-history-sync/CHANGELOG.md
Added new 2026.04.30 changelog entries documenting that fallbackActivity now only runs on route match failures, preventing unintended side effects during successful matches.
Changeset Removal
.changeset/fix-fallback-activity-called-on-match.md
Removed changeset entry after consolidation into official changelogs.
Package Version Bump
extensions/plugin-history-sync/package.json
Updated version from 1.10.0 to 1.10.1 to reflect the patch release.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Version Packages' is generic and vague, using a non-descriptive term that does not convey meaningful information about the specific change being made. Consider using a more specific title that describes the actual fix, such as 'Fix fallbackActivity callback invocation behavior' or include the package version being released.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the fix: the fallbackActivity callback now only triggers when route matching fails, restoring pre-1.8.0 behavior and preventing unintended side effects on successful matches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch changeset-release/main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 30, 2026

  • @stackflow/demo

    yarn add https://pkg.pr.new/@stackflow/link@708.tgz
    
    yarn add https://pkg.pr.new/@stackflow/plugin-history-sync@708.tgz
    
    yarn add https://pkg.pr.new/@stackflow/plugin-preload@708.tgz
    

commit: 739e079

@orionmiz orionmiz merged commit 20c719d into main Apr 30, 2026
6 of 9 checks passed
@orionmiz orionmiz deleted the changeset-release/main branch April 30, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants