fix(windows): enable secp256k1 recovery module in Windows builders#12
Merged
Conversation
The CMake build of libsecp256k1 defaults SECP256K1_ENABLE_MODULE_RECOVERY to OFF, unlike the autotools builds used by build_linux.dart, build_macos.dart, and build_wasm.dart which pass --enable-module-recovery. As a result, secp256k1.dll built by build_windows.dart (and the WSL and docker cross-compile variants) lacked secp256k1_ecdsa_sign_recoverable and the other recovery module exports, breaking recoverable ECDSA message signing (MessageSignature) on Windows with: Invalid argument(s): Failed to lookup symbol 'secp256k1_ecdsa_sign_recoverable': The specified procedure could not be found. (error code: 127) Pass -DSECP256K1_ENABLE_MODULE_RECOVERY=ON in all three Windows builders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake build of libsecp256k1 defaults SECP256K1_ENABLE_MODULE_RECOVERY to OFF, unlike the autotools builds used by build_linux.dart, build_macos.dart, and build_wasm.dart which pass --enable-module-recovery. As a result, secp256k1.dll built by build_windows.dart (and the WSL and docker cross-compile variants) lacked secp256k1_ecdsa_sign_recoverable and the other recovery module exports, breaking recoverable ECDSA message signing (MessageSignature) on Windows with:
Invalid argument(s): Failed to lookup symbol
'secp256k1_ecdsa_sign_recoverable': The specified procedure could not
be found. (error code: 127)
Pass -DSECP256K1_ENABLE_MODULE_RECOVERY=ON in all three Windows builders.