Skip to content

kt/data/kernels.yaml: Add kernel-src-tree-tools repo#69

Merged
roxanan1996 merged 2 commits into
mainlinefrom
{rnicolescu}_kt_setup_add_kernel-src-tree-tools
May 21, 2026
Merged

kt/data/kernels.yaml: Add kernel-src-tree-tools repo#69
roxanan1996 merged 2 commits into
mainlinefrom
{rnicolescu}_kt_setup_add_kernel-src-tree-tools

Conversation

@roxanan1996
Copy link
Copy Markdown
Contributor

@roxanan1996 roxanan1996 commented May 21, 2026

kt/data/kernels.yaml: Add kernel-src-tree-tools repo

So that it will be cloned/updated during kt setup. Because users will probably have local unstaged changes, the current git pull --rebase will fail. The error is caught but kt setup will continue to clone/update the rest of the repos.

While at it, update dostring for setup_repo that was not up to date.

Copilot AI review requested due to automatic review settings May 21, 2026 13:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the kernel-src-tree-tools repository to kt’s configured common repos and adjusts kt setup to continue processing other repos even if a clone/pull fails (e.g., due to local unstaged changes causing pull --rebase to fail).

Changes:

  • Add kernel-src-tree-tools to kt/data/kernels.yaml so it’s cloned/updated during kt setup.
  • Wrap git clone/pull errors in a RepoInfoException from RepoInfo.setup_repo().
  • Catch RepoInfoException in kt setup and log an error instead of aborting the whole setup.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
kt/ktlib/repo.py Adds RepoInfoException and wraps clone/update git failures so callers can handle them.
kt/data/kernels.yaml Registers kernel-src-tree-tools under common_repos.
kt/commands/setup/impl.py Catches repo setup/update failures and continues with remaining repos.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread kt/ktlib/repo.py Outdated
Comment thread kt/ktlib/repo.py Outdated
Comment thread kt/ktlib/repo.py Outdated
Comment thread kt/commands/setup/impl.py Outdated
@roxanan1996 roxanan1996 force-pushed the {rnicolescu}_kt_setup_add_kernel-src-tree-tools branch 2 times, most recently from 459cd8e to c436a7c Compare May 21, 2026 13:37
Copilot AI review requested due to automatic review settings May 21, 2026 13:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread kt/ktlib/repo.py Outdated
Comment thread kt/ktlib/repo.py
Comment thread kt/ktlib/repo.py
Comment thread kt/commands/setup/impl.py Outdated
So that it will be cloned/updated during kt setup.
Because users will probably have local unstaged changes, the current
git pull --rebase will fail. The error is caught but kt setup will continue
to clone/update the rest of the repos.

Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
@roxanan1996 roxanan1996 force-pushed the {rnicolescu}_kt_setup_add_kernel-src-tree-tools branch from c436a7c to a99af98 Compare May 21, 2026 13:47
There is no override parameter.

Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
Copilot AI review requested due to automatic review settings May 21, 2026 13:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread kt/ktlib/repo.py
@roxanan1996 roxanan1996 merged commit 3f734e7 into mainline May 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants