Skip to content

Upgrade to Node 22 as 20 is EOL #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cigamit merged 1 commit into from
May 23, 2026
Merged

Upgrade to Node 22 as 20 is EOL #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions awx/ui/config/webpackDevServer.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ const sockHost = process.env.WDS_SOCKET_HOST;
const sockPath = process.env.WDS_SOCKET_PATH; // default: '/ws'
const sockPort = process.env.WDS_SOCKET_PORT;

module.exports = function (proxy, allowedHost) {
module.exports = function (proxy, allowedHost, proxyOptions = {}) {
const { createProxyMiddleware } = proxyOptions;
const disableFirewall =
!proxy || process.env.DANGEROUSLY_DISABLE_HOST_CHECK === 'true';
return {
Expand Down Expand Up @@ -111,7 +112,7 @@ module.exports = function (proxy, allowedHost) {

if (fs.existsSync(paths.proxySetup)) {
// This registers user provided middleware for proxy reasons
require(paths.proxySetup)(devServer.app);
require(paths.proxySetup)(devServer.app, createProxyMiddleware);
}

// Redirect to `PUBLIC_URL` or `homepage` from `package.json` if url not match
Expand Down
55 changes: 32 additions & 23 deletions awx/ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions awx/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"homepage": ".",
"private": true,
"engines": {
"node": ">=20.19.0"
"node": ">=22.19.0"
Comment thread
cigamit marked this conversation as resolved.
},
"dependencies": {
"@lingui/react": "^5.4.0",
Expand Down Expand Up @@ -82,7 +82,7 @@
"file-loader": "^6.2.0",
"fs-extra": "^11.3.5",
"html-webpack-plugin": "^5.6.7",
"http-proxy-middleware": "3.0.5",
"http-proxy-middleware": "4.0.0",
"inject-manifest-plugin": "^0.6.5",
"jest": "^30.3.0",
"jest-environment-jsdom": "^30.3.0",
Expand Down
9 changes: 6 additions & 3 deletions awx/ui/scripts/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ if (process.env.HOST) {
// browserslist defaults.
const { checkBrowsers } = require('react-dev-utils/browsersHelper');
checkBrowsers(paths.appPath, isInteractive)
.then(() => {
.then(async () => {
// We attempt to use the default port but if it is busy, we offer the user to
// run on a different port. `choosePort()` Promise resolves to the next free port.
return choosePort(HOST, DEFAULT_PORT);
})
Comment thread
cigamit marked this conversation as resolved.
.then(port => {
.then(async port => {
if (port == null) {
// We have not found a port.
return;
Expand Down Expand Up @@ -106,9 +106,12 @@ checkBrowsers(paths.appPath, isInteractive)
paths.appPublic,
paths.publicUrlOrPath
);
const { createProxyMiddleware } = await import('http-proxy-middleware');
// Serve webpack assets generated by the compiler over a web server.
const serverConfig = {
...createDevServerConfig(proxyConfig, urls.lanUrlForConfig),
...createDevServerConfig(proxyConfig, urls.lanUrlForConfig, {
createProxyMiddleware,
}),
host: HOST,
port,
};
Expand Down
11 changes: 7 additions & 4 deletions awx/ui/src/setupProxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
const { legacyCreateProxyMiddleware } = require('http-proxy-middleware');

const TARGET = process.env.TARGET || 'https://localhost:8043';

module.exports = (app) => {
module.exports = (app, createProxyMiddleware) => {
if (typeof createProxyMiddleware !== 'function') {
throw new Error('createProxyMiddleware must be provided to setupProxy');
}

app.use(
legacyCreateProxyMiddleware(['/api', '/websocket', '/sso'], {
createProxyMiddleware({
pathFilter: ['/api', '/websocket', '/sso'],
target: TARGET,
secure: false,
ws: true,
Expand Down
6 changes: 4 additions & 2 deletions tools/ansible/roles/dockerfile/templates/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ USER root
RUN dnf -y update && dnf install -y 'dnf-command(config-manager)' && \
dnf config-manager --set-enabled crb && \
dnf module reset nodejs -y && \
dnf module enable nodejs:20 -y && \
dnf module enable nodejs:22 -y && \
dnf -y install \
iputils \
gcc \
Expand All @@ -40,6 +40,7 @@ RUN dnf -y update && dnf install -y 'dnf-command(config-manager)' && \
make \
{% if not headless|bool %}
nodejs \
npm \
{% endif %}
nss \
openldap-devel \
Expand Down Expand Up @@ -149,7 +150,7 @@ RUN pip3.12 install --no-cache-dir -vv virtualenv supervisor dumb-init build &&
{% if (build_dev|bool) or (kube_dev|bool) %}
# Install development/test requirements
RUN dnf module reset nodejs -y && \
dnf module enable nodejs:20 -y && \
dnf module enable nodejs:22 -y && \
dnf -y install \
crun \
gdb \
Expand All @@ -167,6 +168,7 @@ RUN dnf module reset nodejs -y && \
libpq-devel \
nodejs \
nss \
npm \
make \
patch \
socat \
Expand Down