Skip to content

Migrate to paramstyle="pyformat", following crate-python 2.2.0#266

Merged
bgunebakan merged 16 commits into
mainfrom
paramstyle-pyformat
Jun 17, 2026
Merged

Migrate to paramstyle="pyformat", following crate-python 2.2.0#266
bgunebakan merged 16 commits into
mainfrom
paramstyle-pyformat

Conversation

@amotl

@amotl amotl commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

About

A few adjustments were necessary to accommodate the test suite to upstream changes in crate-python 2.2.0. The updates show that the improvement might have an impact to downstream users, so we might want to handle it with more care even in retrospective.

References

@coderabbitai

This comment was marked as spam.

@amotl

amotl commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Hi @bgunebakan. Please let me know if you think it makes sense to take over this PR, or otherwise close it without much ado at your disposal if relevant fixes are coming from upstream crate-python, so this patch might no longer be needed. Thanks!

@bgunebakan bgunebakan self-assigned this Jun 9, 2026
Comment thread tests/dict_test.py
Comment thread pyproject.toml Outdated
@bgunebakan bgunebakan marked this pull request as ready for review June 10, 2026 08:33
Comment thread pyproject.toml Outdated

@amotl amotl left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for adjusting my patch properly. Maybe announce some of the changes as "breaking"?

Comment thread tests/dict_test.py
Comment thread tests/update_test.py
Comment thread tests/vector_test.py

@kneth kneth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good change, but we need to explain it carefully in CHANGES.md as it has a big impact for the users' code.

@amotl

amotl commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

[The change] has a big impact for the users' code.

Maybe bring in a major version bump at the same time to signal this?

@bgunebakan

Copy link
Copy Markdown
Contributor

It is a good change, but we need to explain it carefully in CHANGES.md as it has a big impact for the users' code.

Thanks, I extended CHANGES.md file with more info about breaking changes.

@mfussenegger mfussenegger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion for the changes entry.

Otherwise lgtm - but would be great if this could be squashed into 2 commits: One that drops support for the outdated python versions and another one that bumps crate-python + makes the pyformat changes.

Comment thread CHANGES.md Outdated
@bgunebakan bgunebakan merged commit beef8d2 into main Jun 17, 2026
27 checks passed
@bgunebakan bgunebakan deleted the paramstyle-pyformat branch June 17, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants