Migrate to paramstyle="pyformat", following crate-python 2.2.0#266
Conversation
This comment was marked as spam.
This comment was marked as spam.
fec5468 to
c58b587
Compare
|
Hi @bgunebakan. Please let me know if you think it makes sense to take over this PR, or otherwise close it without much ado at your disposal if relevant fixes are coming from upstream crate-python, so this patch might no longer be needed. Thanks! |
kneth
left a comment
There was a problem hiding this comment.
It is a good change, but we need to explain it carefully in CHANGES.md as it has a big impact for the users' code.
Maybe bring in a major version bump at the same time to signal this? |
Thanks, I extended |
mfussenegger
left a comment
There was a problem hiding this comment.
Left a suggestion for the changes entry.
Otherwise lgtm - but would be great if this could be squashed into 2 commits: One that drops support for the outdated python versions and another one that bumps crate-python + makes the pyformat changes.
About
A few adjustments were necessary to accommodate the test suite to upstream changes in crate-python 2.2.0. The updates show that the improvement might have an impact to downstream users, so we might want to handle it with more care even in retrospective.
References