[TS-38628] [Agent] Kotlin Migration#855
Open
Avanatiker wants to merge 37 commits intomasterfrom
Open
Conversation
DreierF
requested changes
May 4, 2026
| inputStream: JarInputStream, | ||
| archiveName: String?, | ||
| recursiveSearch: Boolean, | ||
| isRootArchive: Boolean = true |
Contributor
There was a problem hiding this comment.
Out of curiosity: Why was this needed? The Java version didn't have that parameter.
| // vfs:/content/helloworld.war/WEB-INF/classes | ||
| // Next, we try to extract the artefact URL from it, e.g., vfs:/content/helloworld.war | ||
| val artefactUrl = extractArtefactUrl(jarOrClassFolderUrl) | ||
| val virtualFile = URI.create(artefactUrl).toURL().openConnection().getContent() |
Contributor
There was a problem hiding this comment.
URI.create is stricter about percent-encoding compared to new URL and JBoss VFS-style URLs with literal spaces may now throw.
| */ | ||
| abstract class AgentBase( | ||
| /** The agent options. */ | ||
| @JvmField var options: AgentOptions |
Contributor
There was a problem hiding this comment.
Why does this need @JvmField? Same for controller?
| /** | ||
| * Static setter to inject the [TestwiseCoverageAgent] to the resource. | ||
| */ | ||
| @JvmStatic |
| if (options.teamscaleServer.configId == null) return | ||
| if (!options.teamscaleServer.isConfiguredForServerConnection) { | ||
| throw AgentOptionParseException( | ||
| "Config-id '${options.teamscaleServer.configId}' specified without teamscale url/user/accessKey! These options must be provided locally via config-file or command line argument." |
Contributor
There was a problem hiding this comment.
The error message was much more specific on master compared to this version here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating the agent to kotlin