Fix #14634: Inconsistent AST for array declarations#8610
Open
ludviggunne wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
danmar
approved these changes
Jul 14, 2026
pfultz2
reviewed
Jul 14, 2026
| const Settings& settings, | ||
| SourceLocation loc) | ||
| SourceLocation loc, | ||
| bool recurseNamespaces) |
Contributor
There was a problem hiding this comment.
Why do we pass this as a flag? It is never set to false.
Collaborator
Author
There was a problem hiding this comment.
It's set to false here: https://github.com/cppcheck-opensource/cppcheck/pull/8610/changes#diff-49c0f9d6942f6808cf091d306b42ae4639ff837acf2dcad90c28ed5c70cf850dR246. I wanted a way to propagate values both up and down namespace "stacks" without causing infinite recursion. I'm not super familiar with the value flow code though so there might be a better way.
| Value value, | ||
| const Settings& settings, | ||
| SourceLocation loc) | ||
| SourceLocation loc, |
Contributor
There was a problem hiding this comment.
The SourceLocation should always be the last parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.