Fix #901 Improve out-of-bounds check to detect error with sprintf()#8473
Open
chrchr-github wants to merge 1 commit intocppcheck-opensource:mainfrom
Open
Fix #901 Improve out-of-bounds check to detect error with sprintf()#8473chrchr-github wants to merge 1 commit intocppcheck-opensource:mainfrom
chrchr-github wants to merge 1 commit intocppcheck-opensource:mainfrom
Conversation
…or with sprintf()
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
chrchr-github
commented
Apr 21, 2026
| if (inputArgNr < parameters.size() && parameters[inputArgNr]->tokType() == Token::eString) | ||
| parameterLength = Token::getStrLength(parameters[inputArgNr]); | ||
| if (inputArgNr < parameters.size()) | ||
| parameterLength = ValueFlow::valueFlowGetStrLength(parameters[inputArgNr], settings); |
Collaborator
Author
There was a problem hiding this comment.
Looks like a false positive.
Collaborator
There was a problem hiding this comment.
I agree. And it might be fixed in latest cppcheck premium I fail to reproduce..
danmar
reviewed
Apr 25, 2026
| "}", settings); | ||
| ASSERT_EQUALS("", errout_str()); | ||
|
|
||
| check("void f() {\n" // #901 |
Collaborator
There was a problem hiding this comment.
Are there some related test to ensure there is not false positives. I.e. if a size is 2 instead.
| if (inputArgNr < parameters.size() && parameters[inputArgNr]->tokType() == Token::eString) | ||
| parameterLength = Token::getStrLength(parameters[inputArgNr]); | ||
| if (inputArgNr < parameters.size()) | ||
| parameterLength = ValueFlow::valueFlowGetStrLength(parameters[inputArgNr], settings); |
Collaborator
There was a problem hiding this comment.
I agree. And it might be fixed in latest cppcheck premium I fail to reproduce..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.