refactor: add colors to --help output and uniform logging#374
Conversation
Following DRY principal, I unified all logging implementation used in the workspace to clang-tools-manager crate. I also took the time to add colors to all `--help` output. These colors still adhere to `FORCE`, `CLICOLOR`, `CLICOLOR_FORCE`, and `NO_COLOR` env vars. The color theme resides in the same logger module used by each binary in the workspace. Lastly, I made clang-tools CLI's `--tool` argument into a repeatable positional argument (with the same default value). PS - I adjusted cargo-nextest config to auto-cancel on tests that get caught in an infinite loop/hang. This happened recently in CI, and had to be cancel manually.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (17)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThe ChangesLogger consolidation, CLI refactor, and dependency cleanup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 92.43% 92.43% -0.01%
==========================================
Files 23 23
Lines 3649 3646 -3
==========================================
- Hits 3373 3370 -3
Misses 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Following DRY principal, I unified all logging implementation used in the workspace to clang-tools-manager crate.
I also took the time to add colors to all
--helpoutput. These colors still adhere toFORCE,CLICOLOR,CLICOLOR_FORCE, andNO_COLORenv vars. The color theme resides in the same logger module used by each binary in the workspace.Lastly, I made clang-tools CLI's
--toolargument into a repeatable positional argument (with the same default value).PS - I adjusted cargo-nextest config to auto-cancel on tests that get caught in an infinite loop/hang. This happened recently in CI, and had it to be cancel manually.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores