Improve per-tenant alert generator URL template#7458
Open
CharlieTLe wants to merge 1 commit intocortexproject:masterfrom
Open
Improve per-tenant alert generator URL template#7458CharlieTLe wants to merge 1 commit intocortexproject:masterfrom
CharlieTLe wants to merge 1 commit intocortexproject:masterfrom
Conversation
dosubot
Bot
added
component/rules
Add a jsonEscape function to the generator URL template func map that escapes strings for embedding inside JSON string values (e.g., " → \"). This is needed when the expression is placed inside a JSON-encoded URL parameter like Grafana's panes, where bare double quotes would break the JSON structure. - Register jsonEscape in template func map and validation - Update runtime-config.yaml and docs to use jsonEscape - Add test for expression with double quotes - Add AlwaysFiringWithQuotes demo alert to both tenants - Regenerate config docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Charlie Le <charlie_le@apple.com>
SungJin1212
approved these changes
Apr 28, 2026
Member
SungJin1212
left a comment
SungJin1212
left a comment
There was a problem hiding this comment.
LGTM, can you add a changelog?
Member
|
@CharlieTLe just add it to the existing changelog for this |
friedrichg
approved these changes
Apr 28, 2026
yeya24
reviewed
May 1, 2026
yeya24
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonEscapetemplate function for generator URL templates that escapes strings for embedding inside JSON string values (e.g.,"→\"). This is needed when the expression is placed inside a JSON-encoded URL parameter like Grafana'spanes, where bare double quotes in PromQL expressions like{job\!="foo"}would break the JSON structure.{{ urlquery (jsonEscape .Expression) }}jsonEscapestub in validation so templates using it pass parsingAlwaysFiringWithQuotesdemo alert to both tenants to exercise the escapingmake docTest plan
%5C%22encodingAlwaysFiringWithQuotesalert withcount(up{job\!="nonexistent"} or vector(1))produces correct generator URL with%5C%22🤖 Generated with Claude Code