Skip to content

man: --regex=REGEX is wrongly documented for crun delete and crun kill commands#2111

Merged
giuseppe merged 1 commit into
containers:mainfrom
leonardomoreira00:bug/fix-man-page-delete-and-kill-regex
Jun 22, 2026
Merged

man: --regex=REGEX is wrongly documented for crun delete and crun kill commands#2111
giuseppe merged 1 commit into
containers:mainfrom
leonardomoreira00:bug/fix-man-page-delete-and-kill-regex

Conversation

@leonardomoreira00

@leonardomoreira00 leonardomoreira00 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

The crun delete and crun kill commands are expecting the CONTAINER as the --regex expression.
It doesn't match the behavior of the CLI, that describes it as --regex=Regex.

For details see the issue:

Closes: #2110

@leonardomoreira00 leonardomoreira00 changed the title Bug/fix man page delete and kill regex man: --regex=REGEX is wrongly documented for crun delete and crun kill commands Jun 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in crun.1 and crun.1.md to clarify that the --regex option treats the CONTAINER argument itself as a regular expression for the delete and kill commands. The reviewer feedback suggests italicizing the CONTAINER placeholder in both the troff and markdown files to maintain formatting consistency across the documentation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread crun.1 Outdated
Comment thread crun.1 Outdated
Comment thread crun.1.md Outdated
Comment thread crun.1.md Outdated
@leonardomoreira00 leonardomoreira00 force-pushed the bug/fix-man-page-delete-and-kill-regex branch from e5c21ce to 6aa5b2f Compare June 21, 2026 23:54
@packit-as-a-service

Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service

Copy link
Copy Markdown

TMT tests failed. @containers/packit-build please check.

@giuseppe

Copy link
Copy Markdown
Member

thanks for the patch. Please squash the two commits

@leonardomoreira00 leonardomoreira00 force-pushed the bug/fix-man-page-delete-and-kill-regex branch from 6aa5b2f to 6705e07 Compare June 22, 2026 10:12
crun delete and crun kill commands are expecting the --regex expression
as the name of the container.
fix wrong documentation --regex=Regex

review: fix gemini review findings

Signed-off-by: Leonardo Moreira <leonardo.moreira.coutinho@gmail.com>
@leonardomoreira00 leonardomoreira00 force-pushed the bug/fix-man-page-delete-and-kill-regex branch from 6705e07 to e93dc52 Compare June 22, 2026 10:13

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe

Copy link
Copy Markdown
Member

Closes: #2110

@giuseppe giuseppe merged commit 3779c68 into containers:main Jun 22, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

man: --regex=REGEX is wrongly documented for crun delete and crun kill

2 participants