cgroup: fix memory issue when resizing array of strings

[leonardomoreira00]

The function append_systemd_annotation() initializes the array of strings pointers char ** using the correct byte size, but when it is resized, the code uses a hard-coded element count instead of the actual number of bytes required:

For details see the issue:

• cgroup: systemd annotation arrays can corrupt heap when more than 31 entries are parsed #2106

Closes: #2106

[gemini-code-assist]

Code Review

This pull request fixes a memory allocation bug in src/libcrun/cgroup-systemd.c where xrealloc was being called with the number of elements instead of the total byte size. The fix correctly multiplies parts_size by sizeof(char *). There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[giuseppe]

LGTM

[giuseppe]

please amend the change suggested by make clang-format:

diff --git a/src/libcrun/cgroup-systemd.c b/src/libcrun/cgroup-systemd.c
index 9c43148..793da6f 100644
--- a/src/libcrun/cgroup-systemd.c
+++ b/src/libcrun/cgroup-systemd.c
@@ -671,7 +671,7 @@ append_systemd_annotation (sd_bus_message *m, const char *name, size_t name_len,
           if (n_parts == parts_size - 1)
             {
               parts_size += 32;
-              parts = xrealloc (parts, sizeof(char *) * parts_size);
+              parts = xrealloc (parts, sizeof (char *) * parts_size);
             }
           parts[n_parts] = NULL;
           if (next == NULL)

[giuseppe]

LGTM

[leonardomoreira00]

please amend the change suggested by make clang-format:

diff --git a/src/libcrun/cgroup-systemd.c b/src/libcrun/cgroup-systemd.c
index 9c43148..793da6f 100644
--- a/src/libcrun/cgroup-systemd.c
+++ b/src/libcrun/cgroup-systemd.c
@@ -671,7 +671,7 @@ append_systemd_annotation (sd_bus_message *m, const char *name, size_t name_len,
           if (n_parts == parts_size - 1)
             {
               parts_size += 32;
-              parts = xrealloc (parts, sizeof(char *) * parts_size);
+              parts = xrealloc (parts, sizeof (char *) * parts_size);
             }
           parts[n_parts] = NULL;
           if (next == NULL)

Fixed!
Sorry, I am still familiarizing myself with the repo in the small windows of time I get between newborn duties.
I overlook it when I was reading the contribution guide. Next time I will do it right 👍