Add minimal modal run to model dry deposition#211
Open
zdaq12 wants to merge 37 commits into
Open
Conversation
…e modal run; handle input and output for processing
… default parameters
Collaborator
|
closing and reopening to trigger codecov analysis |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 77.45% 74.97% -2.48%
==========================================
Files 55 56 +1
Lines 9420 9738 +318
==========================================
+ Hits 7296 7301 +5
- Misses 2124 2437 +313 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jcurtis2
reviewed
Apr 23, 2026
Collaborator
There was a problem hiding this comment.
Looks pretty good in my first pass.
- I think we need to add some protections to the modal model. For example, I can attempt to run with emissions/dilution (it won't complain) but they won't do anything. However these are in the spec file (they're zero for the purpose of this scenario but it leads one to think that maybe they could be changed) and they are read in (due to other PartMC subroutines). I think maybe we just add some asserts in partmc_modal to warn/error out on unsupported behavior.
- Similarly, I could also attempt to turn coagulation on. This isn't actually read anywhere. I guess what we really need is an input_format_modal similar to how we have them for input_format_particle, sectional to say what is supported.
- We do need to figure out what to do with the scenario. Honestly I'm wondering if we should consider switching this scenario to being a test case (this is what we did with the immersion freezing). This scenario already fits in pretty well with what is found in
test/loss. Making it a test would also make codecov happy. Alternatively, I think if it wants to reach scenario levels by making it interesting, we could consider running it for the particle-resolved case and/or sectional case. Just something to consider.
jcurtis2
reviewed
Apr 23, 2026
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.