Skip to content

chore: Fix generation of javadoc comments#3

Merged
nmorgan-cb merged 2 commits into
mainfrom
nm/fix-javadoc-gen
Jun 23, 2026
Merged

chore: Fix generation of javadoc comments#3
nmorgan-cb merged 2 commits into
mainfrom
nm/fix-javadoc-gen

Conversation

@nmorgan-cb

Copy link
Copy Markdown
Contributor

Description

  • Maven Central publish: Javadoc generation failed on model comments containing >, >=, or -> from OpenAPI descriptions (e.g. margin threshold comparisons, call priority ordering). Model generator now HTML-escapes Javadoc at emission time; affected generated model Javadoc updated accordingly.
  • CI: PR workflow runs mvn javadoc:javadoc so Javadoc failures are caught before release.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency update
  • Refactor / cleanup
  • Other (describe below)

Checklist

  • Tests included / updated
  • Changelog updated
  • Version bump if needed

@nmorgan-cb nmorgan-cb requested a review from a team as a code owner June 23, 2026 15:23
@cb-heimdall

cb-heimdall commented Jun 23, 2026

Copy link
Copy Markdown

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

rcbgr
rcbgr previously approved these changes Jun 23, 2026
nmorgan-cb and others added 2 commits June 23, 2026 11:44
Javadoc generation failed during Maven Central publish because doclint
rejects comparison operators in OpenAPI-sourced model comments. Disable
doclint in maven-javadoc-plugin (matching AWS SDK pattern) and add CI
javadoc step plus decodeHtmlEntities regression tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@nmorgan-cb nmorgan-cb merged commit 4ea5950 into main Jun 23, 2026
10 checks passed
@nmorgan-cb nmorgan-cb deleted the nm/fix-javadoc-gen branch June 23, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants