Fix get_item() returning HTTP 500 for a not-found snippet#400
Merged
sheabunge merged 1 commit intoJun 4, 2026
Merged
Conversation
A snippet that doesn't exist should return 404, not 500. HTTP 500 signals a server error; 404 signals that the resource doesn't exist. The activate_item() and deactivate_item() methods in this same file already return 404 for the same not-found condition — get_item() was the outlier. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts the REST API error response for missing snippets to use an appropriate HTTP status code.
Changes:
- Update the
rest_cannot_geterror status from500to404when a snippet is not found.
Member
|
Great catch – thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
get_item() in the REST controller returns HTTP 500 when a snippet ID doesn't exist. That should be 404 — 500 means something went wrong on the server, 404 means the resource doesn't exist. The activate_item() and deactivate_item() methods in the same file already return 404 for the same not-found condition, so get_item() was just the odd one out. One digit change.
(full disclosure, I used AI help with the testing and tweaks - Christopher)