SANDBOX-1889: change default phoneLookupMode from log to disabled#515
Open
fbm3307 wants to merge 1 commit into
Open
SANDBOX-1889: change default phoneLookupMode from log to disabled#515fbm3307 wants to merge 1 commit into
fbm3307 wants to merge 1 commit into
Conversation
Update the default value for phoneLookupMode to "disabled" so that environments which haven't explicitly opted in no longer call the Twilio Lookup API. Production and staging are unaffected as they already set phoneLookupMode to "enabled" explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
WalkthroughThe default value for the ChangesphoneLookupMode default value update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This was referenced Jul 6, 2026
Open
MatousJobanek
approved these changes
Jul 6, 2026
alexeykazakov
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Update the default value for phoneLookupMode to "disabled" . Production and staging are unaffected as they already set phoneLookupMode to "enabled" explicitly.
Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? NA
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.
registration service: codeready-toolchain/registration-service#604
Toolchain-e2e: codeready-toolchain/toolchain-e2e#1292
Assisted by : Cursor
Summary by CodeRabbit
logtodisabled.