Skip to content

SANDBOX-1889: change default phoneLookupMode from log to disabled#515

Open
fbm3307 wants to merge 1 commit into
codeready-toolchain:masterfrom
fbm3307:phone-lookup-default-disabled
Open

SANDBOX-1889: change default phoneLookupMode from log to disabled#515
fbm3307 wants to merge 1 commit into
codeready-toolchain:masterfrom
fbm3307:phone-lookup-default-disabled

Conversation

@fbm3307

@fbm3307 fbm3307 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

Update the default value for phoneLookupMode to "disabled" . Production and staging are unaffected as they already set phoneLookupMode to "enabled" explicitly.

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? yes

  3. In case of new CRD, did you the following? NA

  4. In case other projects are changed, please provides PR links.

registration service: codeready-toolchain/registration-service#604
Toolchain-e2e: codeready-toolchain/toolchain-e2e#1292

Assisted by : Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Updated the default setting for phone number lookup verification from log to disabled.
    • Clarified the available phone lookup modes so the behavior is easier to understand when configuring verification.

Update the default value for phoneLookupMode to "disabled" so that
environments which haven't explicitly opted in no longer call the
Twilio Lookup API. Production and staging are unaffected as they
already set phoneLookupMode to "enabled" explicitly.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Walkthrough

The default value for the phoneLookupMode field in RegistrationServiceVerificationConfig is changed from "log" to "disabled", with corresponding updates to the kubebuilder default directive, field documentation, generated OpenAPI schema, and API reference documentation.

Changes

phoneLookupMode default value update

Layer / File(s) Summary
Type default and documentation
api/v1alpha1/toolchainconfig_types.go
The +kubebuilder:default directive and inline documentation for phoneLookupMode are updated so the default is "disabled" instead of "log".
Generated schema and docs sync
api/v1alpha1/zz_generated.openapi.go, api/v1alpha1/docs/apiref.adoc
The generated OpenAPI description and the API reference documentation are updated to reflect the new "disabled" default.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • codeready-toolchain/api#509: Both PRs modify the default value of RegistrationServiceVerificationConfig.phoneLookupMode across type definitions, generated OpenAPI schema, and docs.

Suggested labels: feature

Suggested reviewers: alexeykazakov, metlos, MatousJobanek

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: changing the phoneLookupMode default from log to disabled.
Description check ✅ Passed The description includes the required goal and checks sections and is mostly complete, with only a missing member-operator PR link.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants