Skip to content

SANDBOX-1889: change default phoneLookupMode from log to disabled#514

Closed
fbm3307 wants to merge 1 commit into
codeready-toolchain:masterfrom
fbm3307:phone-lookup-default-disabled
Closed

SANDBOX-1889: change default phoneLookupMode from log to disabled#514
fbm3307 wants to merge 1 commit into
codeready-toolchain:masterfrom
fbm3307:phone-lookup-default-disabled

Conversation

@fbm3307

@fbm3307 fbm3307 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

Update the default value for phoneLookupMode to "disabled" .
Production and staging are unaffected as they already set phoneLookupMode to "enabled" explicitly.

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? yes/no

  3. In case of new CRD, did you the following? NA

  4. In case other projects are changed, please provides PR links.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the default value for phone lookup mode from “log” to “disabled” when the setting is not specified.
    • Reflected the new default consistently in the user-facing API reference and schema documentation.

Update the default value for phoneLookupMode to "disabled" so that
environments which haven't explicitly opted in no longer call the
Twilio Lookup API. Production and staging are unaffected as they
already set phoneLookupMode to "enabled" explicitly.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Walkthrough

The default value for the phoneLookupMode field in RegistrationServiceVerificationConfig is changed from "log" to "disabled". This update is reflected in the Go type's kubebuilder default annotation, the generated OpenAPI schema documentation, and the API reference documentation.

Changes

phoneLookupMode default update

Layer / File(s) Summary
Default value change and documentation sync
api/v1alpha1/toolchainconfig_types.go, api/v1alpha1/zz_generated.openapi.go, api/v1alpha1/docs/apiref.adoc
The +kubebuilder:default annotation and comment for phoneLookupMode change from "log" to "disabled", with matching updates to the generated OpenAPI description and API reference table.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • codeready-toolchain/api#509: Directly related by updating the same RegistrationServiceVerificationConfig.phoneLookupMode CRD/docs/OpenAPI default value.

Suggested reviewers: alexeykazakov, MatousJobanek

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is specific and accurately summarizes the main change: changing phoneLookupMode's default from log to disabled.
Description check ✅ Passed The description follows the template and covers the change and checks, with only the second check left as a yes/no placeholder.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@fbm3307

fbm3307 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

wrong branch names

@fbm3307 fbm3307 closed this Jul 6, 2026
@fbm3307 fbm3307 deleted the phone-lookup-default-disabled branch July 6, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant