Potential fix for code scanning alert no. 95: Uncontrolled data used in path expression#726
Merged
Conversation
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
alitokmen
marked this pull request as ready for review
July 14, 2026 04:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/codehaus-cargo/cargo/security/code-scanning/95
The safest minimal fix is to validate and normalize
relativeFileinFileManager.saveFile(...)before appending it to the workspace path, then enforce that the resolved target remains inside the workspace directory.Best concrete approach (without changing intended functionality):
extensions/daemon/webapp/src/main/java/org/codehaus/cargo/daemon/file/FileManager.java:workspaceDir.resolve(relativeFile).normalize(),saveFile(String relativeFile, InputStream inputStream)andsaveFile(String handleId, String relativeFile, InputStream inputStream)so both write paths are protected.java.nio.file.Pathandjava.nio.file.Pathsimports.IllegalArgumentExceptionon invalid path input (keeps behavior explicit and avoids silent rewriting).This preserves existing behavior for valid relative inputs while blocking traversal and absolute-path abuse.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.