fix: remove logging.basicConfig from __init__.py (#155)#194
Open
cschanhniem wants to merge 1 commit into
Open
Conversation
… pollution Calling logging.basicConfig() at import time configures the root logger for the entire Python process. This interferes with logging setups in applications that use cocoindex-code as a dependency -- any consumer that does 'import cocoindex_code' gets its root logger silently reconfigured. The daemon already handles its own logging setup in daemon.main() with file + stream handlers. Removing the module-level basicConfig is safe and follows the standard library pattern: libraries use getLogger(__name__), applications configure the root logger.
|
Duplicate of #155. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155.
Removes the
logging.basicConfig(level=logging.WARNING)call from__init__.py.Problem: Calling
logging.basicConfig()at import time configures the root logger for the entire Python process. Any application that doesimport cocoindex_codegets its root logger silently reconfigured, which interferes with logging setups in consuming projects.Fix: Remove the call entirely. The daemon already handles its own logging setup in
daemon.main()with proper file + stream handlers. Libraries should not configure the root logger — that's the application's responsibility.