Scroll affordance fixes, login background right-sizing#5582
Open
nabramovitz wants to merge 5 commits into
Open
Scroll affordance fixes, login background right-sizing#5582nabramovitz wants to merge 5 commits into
nabramovitz wants to merge 5 commits into
Conversation
The dashboard shell's bottom scroll shadow only updated on scroll events and a delayed NavigationEnd hook, so it was missing on pages whose content rendered after the 100ms mark and went stale when content shrank without a scroll (e.g. closing a native <details> accordion on the diagnostics page). Measure once in ngAfterViewInit and wire ResizeObserver plus MutationObserver (childList + subtree + attributes, the latter for <details> open-toggles) on the content element, mirroring the signal-list overflow-fade pattern. The NavigationEnd+delay hack is now redundant and removed.
macOS overlay scrollbars are 0px wide when idle, leaving scrollable containers with no affordance at all. Tile grids (every summary tab) scrolled invisibly, as did the role-assignment lists, side panel preview body, kube create-release namespace dropdown and the recent-apps card. Add a global .custom-scrollbar utility (same 6px themed styling the endpoint-register modal and steppers already use locally) and apply it at those sites; tile-grid gets the styling in its own scss since it is the scroll element itself. Also drop the dead overflow-y-auto on the cf summary tab wrapper - its only child is the fit tile-grid, which absorbs all overflow.
Operators can point config.login.backgroundImage at any asset; the branding doc now says what that costs (pre-auth fetch, full re-transfer per visit under no-cache), gives a size budget and sizing recipe, and uses the stock image right-sizing from cloudfoundry#5550 as a worked example.
The stock login background was a 415 kB 1080p JPEG - the heaviest asset left on the pre-auth page after the cloudfoundry#5560 fix wave, and it re-transfers in full on every warm visit under the blanket no-cache policy (Chromium re-downloads it with a 200, not a 304). Replace it with a 1280x720 WebP at quality 65 (158 kB, -62%). As a background rendered behind the login card the downscale is visually equivalent; same-resolution recompression was measured at only -10..-37% on this high-entropy photo. All default-theme references now point at login-bg.webp; the example-theme and devkit schematic assets are untouched. Also mark *.webp as binary in .gitattributes - the blanket '* text eol=lf' rule would otherwise corrupt any webp whose bytes contain CRLF sequences, and align the branding doc's worked example with the shipped variant. Refs cloudfoundry#5550
norman-abramovitz
approved these changes
Jul 5, 2026
norman-abramovitz
left a comment
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM - but I will need to live verify later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two UX fix groups plus a perf follow-up to #5550, and the dev.133 bump.
Scroll affordance
<details>toggles on the diagnostics page), mirroring the signal-list overflow-fade pattern..custom-scrollbarutility (same 6px themed styling the endpoint-register modal and steppers already used locally) is now applied at those sites; a deadoverflow-y-autowrapper on the cf summary tab is removed.Login background (refs #5550)
.gitattributesnow marks*.webpas binary — the blanket* text eol=lfrule could otherwise corrupt webp files.docs/branding-architecture.mdgives operators a size budget, a sizing recipe, and the measured variants as a worked example.Testing