Ubuntu noble => resolute#643
Merged
Merged
Conversation
CentOS stemcells are no longer built, so this drops dead stages, assets, and code paths. Also removes the default_su_directive override (already removed on ubuntu-noble), which silently overrode the correct 'su root syslog' set globally in ubuntu-logrotate.conf.
Explicitly pass: - GEM_HOME - BUILD_TIME - UBUNTU_ADVANTAGE_TOKEN - UBUNTU_FIPS_USE_IAAS_KERNEL Fixes: ``` sudo: preserving the entire environment is not supported, '--preserve-env' is ignored ubuntu@21f652d6-b208-4386-b0c0-097e26578228:/tmp/build/44575cf5$ set -e ubuntu@21f652d6-b208-4386-b0c0-097e26578228:/tmp/build/44575cf5$ ubuntu@21f652d6-b208-4386-b0c0-097e26578228:/tmp/build/44575cf5$ cd "/tmp/build/44575cf5/bosh-linux-stemcell-builder" ubuntu@21f652d6-b208-4386-b0c0-097e26578228:/tmp/build/44575cf5/bosh-linux-stemcell-builder$ bundle install Bundler 4.0.13 is running, but your lockfile was generated with 2.5.23. Installing Bundler 2.5.23 and restarting using that version. Fetching gem metadata from https://rubygems.org/. Fetching bundler 2.5.23 Retrying download gem from https://rubygems.org/ due to error (2/4): Bundler::PermissionError There was an error while trying to write to `/usr/local/lib/ruby/gems/3.3.0/cache/bundler-2.5.23.gem`. It is likely that you need to grant write permissions for that path. ``` ^ https://bosh.ci.cloudfoundry.org/teams/stemcell/pipelines/ubuntu-resolute-builder/jobs/build-os-image/builds/1#L6a052874:4:13
Remove CentOS-specific code and assets
…VolumePattern in aws_spec.rb
…nvme-on-ali Add NVMe support to Alicloud infrastructure configuration
Revert "Harden monit-access-helper.sh cgroupv2 mount point detection"
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mkocher
approved these changes
Jun 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates stemcell inputs and validations by bumping referenced OS image/agent artifacts and extending infrastructure/test coverage for additional configuration properties and platforms.
Changes:
- Bump
bosh-agentasset references from2.852.0to2.854.0(metalink + version file). - Update Ubuntu Jammy/Noble OS image metalinks to newer published versions/hashes.
- Add/extend specs and infrastructure metadata (AWS agent.json expectations, Alicloud additional cloud properties) and broaden service enablement detection to recognize openSUSE.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| stemcell_builder/stages/image_install_grub/apply.sh | Adds inline documentation clarifying key script variables used during GRUB installation. |
| stemcell_builder/stages/bosh_go_agent/assets/metalink.meta4 | Updates bosh-agent metalink entries (filenames, hashes, URLs, published timestamp) to 2.854.0 artifacts. |
| stemcell_builder/stages/bosh_go_agent/assets/bosh-agent-version | Bumps the recorded bosh-agent version to 2.854.0. |
| image-metalinks/ubuntu-noble/ubuntu-noble.meta4 | Updates Ubuntu Noble OS image + usn-log metalink hashes/sizes and version to 120.0.0. |
| image-metalinks/ubuntu-jammy/ubuntu-jammy.meta4 | Updates Ubuntu Jammy OS image + usn-log metalink hashes/sizes and version to 1089.0.0. |
| bosh-stemcell/spec/stemcells/aws_spec.rb | Adds assertions about new AWS agent.json NVMe instance storage patterns. |
| bosh-stemcell/spec/bosh/stemcell/infrastructure_spec.rb | Adds explicit Alicloud infrastructure expectations, including additional cloud properties. |
| bosh-stemcell/lib/shellout_types/service.rb | Allows service enablement checks to run on openSUSE in addition to Ubuntu. |
| bosh-stemcell/lib/bosh/stemcell/infrastructure.rb | Adds nvme_support to Alicloud additional_cloud_properties. |
| .github/pull_request_template.md | Updates the merge-forward process instructions in the PR template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this repository uses a "Merge Forward" strategy
Changes should be made in the earliest applicable branch, and
merged forward through subsequent branches.
ubuntu-<short_name-N>ubuntu-<short_name-N>intoubuntu-<short_name-N+1>