fix(resolute): remove obsolete metadata_csum workaround and update Az…#632
Conversation
…ure package list Ubuntu 26.04 ships with GRUB 2.12+ which supports metadata_csum_seed natively (fixed upstream June 2021). The sed workaround in system_alicloud/apply.sh was a no-op on Resolute (pattern 'metadata_csum,' does not match 'metadata_csum_seed,') and is no longer needed. Update the Azure stemcell package list to reflect Ubuntu 26.04 (Resolute) changes: kernel cloud-tools bumped from 6.8 to 7.0, python3-pyrsistent replaced by python3-rpds-py, cloud-init-base split added, new jsonschema dependencies added (python3-jsonschema-specifications, python3-referencing), python3-passlib added, python3-setuptools removed (not installed by default in 26.04).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Ubuntu 26.04 (Resolute) stemcell builds for AliCloud and Azure by removing an obsolete ext4 metadata workaround and updating the expected Ubuntu/Azure package lists to match Resolute’s dependency changes.
Changes:
- Removed the AliCloud
metadata_csummke2fs.conf sed workaround from the AliCloud system stage. - Dropped the AliCloud spec assertion that
/etc/mke2fs.confmust not mentionmetadata_csum. - Updated Ubuntu/Azure dpkg expectation lists for Resolute (e.g., linux-cloud-tools 7.0, jsonschema dependency changes, package additions/removals).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| stemcell_builder/stages/system_alicloud/apply.sh | Removes the ext4 metadata workaround previously applied for AliCloud images. |
| bosh-stemcell/spec/stemcells/alicloud_spec.rb | Removes the spec that enforced absence of metadata_csum in mke2fs config. |
| bosh-stemcell/spec/assets/dpkg-list-ubuntu.txt | Updates baseline Ubuntu package expectations (removes python3-setuptools). |
| bosh-stemcell/spec/assets/dpkg-list-ubuntu-azure-additions.txt | Updates Azure-specific package expectations for Resolute (kernel tools + Python dependency set). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| python3-referencing | ||
| python3-requests | ||
| python3-rpds-py | ||
| python3-serial | ||
| python3-setuptools | ||
| python3-urllib3 |
Fix resolute stemcell builds for azure and alicloud.
This PR replaces #631 due to some github wierdness.
AI Slop Summary
Ubuntu 26.04 ships with GRUB 2.12+ which supports metadata_csum_seed
natively (fixed upstream June 2021). The sed workaround in
system_alicloud/apply.sh was a no-op on Resolute (pattern 'metadata_csum,'
does not match 'metadata_csum_seed,') and is no longer needed.
Update the Azure stemcell package list to reflect Ubuntu 26.04 (Resolute)
changes: kernel cloud-tools bumped from 6.8 to 7.0, python3-pyrsistent
replaced by python3-rpds-py, cloud-init-base split added, new jsonschema
dependencies added (python3-jsonschema-specifications, python3-referencing),
python3-passlib added, python3-setuptools removed (not installed by default
in 26.04).