Merge noble => resolute#630
Conversation
Explicitly pass: - GEM_HOME - BUILD_TIME - UBUNTU_ADVANTAGE_TOKEN - UBUNTU_FIPS_USE_IAAS_KERNEL Fixes: ``` sudo: preserving the entire environment is not supported, '--preserve-env' is ignored ubuntu@21f652d6-b208-4386-b0c0-097e26578228:/tmp/build/44575cf5$ set -e ubuntu@21f652d6-b208-4386-b0c0-097e26578228:/tmp/build/44575cf5$ ubuntu@21f652d6-b208-4386-b0c0-097e26578228:/tmp/build/44575cf5$ cd "/tmp/build/44575cf5/bosh-linux-stemcell-builder" ubuntu@21f652d6-b208-4386-b0c0-097e26578228:/tmp/build/44575cf5/bosh-linux-stemcell-builder$ bundle install Bundler 4.0.13 is running, but your lockfile was generated with 2.5.23. Installing Bundler 2.5.23 and restarting using that version. Fetching gem metadata from https://rubygems.org/. Fetching bundler 2.5.23 Retrying download gem from https://rubygems.org/ due to error (2/4): Bundler::PermissionError There was an error while trying to write to `/usr/local/lib/ruby/gems/3.3.0/cache/bundler-2.5.23.gem`. It is likely that you need to grant write permissions for that path. ``` ^ https://bosh.ci.cloudfoundry.org/teams/stemcell/pipelines/ubuntu-resolute-builder/jobs/build-os-image/builds/1#L6a052874:4:13
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR addresses two independent maintenance concerns in the stemcell builder. First, it updates the CI build scripts to preserve environment variables during privileged command execution, particularly the Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
This PR updates Ubuntu OS-image metalinks and adjusts CI task wrappers used to run the build under the ubuntu user, consistent with the repo’s merge-forward workflow between branches.
Changes:
- Bump
ubuntu-nobleandubuntu-jammyOS-image metalinks (hashes/sizes, version numbers, published timestamps). - Update CI build entrypoints to run
bundle exec rake ...with quoted rake arguments and a restrictedsudo --preserve-env=...list.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| image-metalinks/ubuntu-noble/ubuntu-noble.meta4 | Updates OS image + usn-log versions and associated hashes/metadata. |
| image-metalinks/ubuntu-jammy/ubuntu-jammy.meta4 | Updates OS image + usn-log versions and associated hashes/metadata. |
| ci/tasks/os-images/build.sh | Changes sudo invocation (restricted preserved env) and quotes rake task arguments. |
| ci/tasks/build.sh | Changes sudo invocation (restricted preserved env) and quotes rake task arguments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NOTE: this repository uses a "Merge Forward" strategy
Changes should be made in the earliest applicable branch, and
merged forward through subsequent branches.
ubuntu-<short_name>)merge-to-<next_short_name>branchubuntu-<short_name>intomerge-to-<next_short_name>merge-to-<next_short_name>intoubuntu-<next_short_name>