Merge forward Jammy => Noble#619
Conversation
This seems to have been the default on ubuntu for a long time, so removing our overrides to the configuration.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR merges forward Jammy changes into the Noble branch, updating the Jammy OS image references and aligning auditd-related build/test behavior with the distro-provided systemd unit.
Changes:
- Remove the build-time override of
auditd.serviceand rely on the packaged unit file under/lib/systemd/system. - Bump the Jammy metalink to
1080.0.0with updated hashes/sizes. - Update Jammy OS image specs to validate auditd’s systemd unit location/content (but one new assertion currently checks the wrong filesystem).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| stemcell_builder/stages/bosh_audit_ubuntu/apply.sh | Removes custom systemd unit copying/editing for auditd during image build. |
| image-metalinks/ubuntu-jammy/ubuntu-jammy.meta4 | Updates Jammy image + USN log metalink version and checksums. |
| bosh-stemcell/spec/os_image/ubuntu_spec.rb | Adjusts auditd systemd unit expectations to /lib/systemd/system and adds an assertion about not creating an override. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| it "does not create '/etc/systemd/system/auditd.service'" do | ||
| expect(File.exist?("/etc/systemd/system/auditd.service")).to eq(false) | ||
| end | ||
|
|
| <hash type="sha-512">be688838ca8686e5c90689bf2ab585cef1137c999b48c70b92f67a5c34dc15697b5d11c982ed6d71be1e1e7f7b4e0733884aa97c3f7a339a8ed03577cf74be09</hash> | ||
| <hash type="sha-256">01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b</hash> | ||
| <hash type="sha-1">adc83b19e793491b1c6ea0fd8b46cd9f32e592fc</hash> | ||
| <hash type="md5">68b329da9893e34099c7d8ad5cb9c940</hash> | ||
| <size>1</size> |
NOTE: this repository uses a "Merge Forward" strategy
Changes should be made in the earliest applicable branch, and
merged forward through subsequent branches.
ubuntu-<short_name>)merge-to-<next_short_name>branchubuntu-<short_name>intomerge-to-<next_short_name>merge-to-<next_short_name>intoubuntu-<next_short_name>