fix(create-cloudflare): commit spinner blocks GPG passphrase prompt on initial git commit#14767
Open
jasoncabot wants to merge 3 commits into
Open
Conversation
…n initial git commit When running `npm create cloudflare@latest` with `commit.gpgsign` enabled, the initial commit step would shell out to `git commit` while keeping its own animated spinner running (and piping stdio, which spun up a second nested spinner). Any GPG passphrase prompt (e.g. pinentry-curses) draws directly to the terminal and fights those spinners for the screen, so you can't actually type your passphrase - the process just looks stuck until you Ctrl+C. Fixed by stopping the spinner and running `git commit` with inherited stdio, so the prompt behaves exactly like a normal, manually-run `git commit`.
🦋 Changeset detectedLatest commit: b3e5257 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
emily-shen
and removed request for
a team
July 20, 2026 16:49
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
@cloudflare/autoconfig
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has annoyed me for a while but I haven't ever bothered to report / fix it up as I felt it was such a trivial thing.
When running
npm create cloudflare@latestwithcommit.gpgsignenabled, the initial commit step would shell out togit commitwhile keeping its own animated spinner running (and piping stdio, which spun up a second nested spinner).Since I require a passphrase to unlock my GPG key the creation step would always fail at the signing stage and have be quit using ctrl+c before it asked it I wanted to deploy my newly created application.
I tracked this down to the fact that the GPG passphrase prompt (e.g. pinentry-curses) draws directly to the terminal and fights the spinners for the screen, so you can't actually type your passphrase, the process just looks stuck until you Ctrl+C.
Fixed by stopping the spinner and running
git commitwith inherited stdio, so the prompt behaves exactly like a normal, manually-rungit commit.node ./packages/create-cloudflare/bin/c3.js gpg-testlocally and observing it worked with cached / uncached credentials for my signing key whencommit.gpgsign=truewith a passphrase protected keyA picture of a cute animal (not mandatory, but encouraged)