[wrangler] Surface _redirects validation warnings at deploy time (#14694) by allocsys · Pull Request #14709 · cloudflare/workers-sdk

allocsys · 2026-07-15T18:40:05Z

Fixes #14694

What this PR solves

Wrangler's deploy-time _redirects validation didn't respect assets.html_handling when checking for infinite-loop redirect rules. This caused a false "infinite loop" warning for setups like html_handling: "none" with a rule such as / /index.html, since the validator didn't account for HTML handling being disabled.

Fix

parseRedirects() in resolveAssetOptions() now passes htmlHandling: config.assets?.html_handling, matching the behavior already used by the Vite plugin (packages/vite-plugin-cloudflare/src/asset-config.ts).

Tests

Tests included/updated
- html_handling: "none" + a rule like / /index.html no longer produces a false "infinite loop" warning at deploy time
- The same rule with default HTML handling is still correctly flagged as an infinite loop, confirming detection isn't weakened

Documentation

Documentation not necessary because: this fixes a bug in existing validation logic; no new user-facing behavior or config surface is introduced

…re#14694, option 1)

…4694)

changeset-bot · 2026-07-15T18:40:09Z

🦋 Changeset detected

Latest commit: 16eb284

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
wrangler	Patch
@cloudflare/workers-shared	Patch
@cloudflare/deploy-helpers	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch
@cloudflare/remote-bindings	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

workers-devprod · 2026-07-15T19:54:38Z

Codeowners approval required for this PR:

@cloudflare/deploy-config
@cloudflare/wrangler

Show detailed file reviewers

.changeset/warm-redirects-deploy-warning.md: [@cloudflare/wrangler]
packages/deploy-helpers/src/deploy/helpers/assets.ts: [@cloudflare/wrangler]
packages/workers-shared/utils/configuration/constructConfiguration.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/wrangler/src/tests/deploy/assets.test.ts: [@cloudflare/wrangler]

…udflare#14694 review comment) config.assets?.html_handling was already available in this function but wasn't threaded through to the new deploy-time parseRedirects() call, so htmlHandling defaulted to undefined -- which parseRedirects treats as "enabled" -- causing false "infinite loop detected" warnings for users who set html_handling: "none" on rules like `/ /index.html`. Now passes the same option the Vite plugin already passes correctly.

…infinite-loop warning at deploy time Covers the review finding on cloudflare#14709 -- parseRedirects() previously ran with htmlHandling always undefined at deploy time (treated as enabled), so a rule like `/ /index.html` was flagged as an infinite loop even for projects that explicitly disabled HTML handling. Adds a test confirming no warning is produced now that config.assets?.html_handling is threaded through, plus a sanity check that the real infinite-loop case is still caught when HTML handling is left at its default.

allocsys · 2026-07-15T20:57:29Z

Fixed in 018173c — parseRedirects() in resolveAssetOptions() now passes htmlHandling: config.assets?.html_handling, matching what the Vite plugin already does at packages/vite-plugin-cloudflare/src/asset-config.ts.

Added two regression tests in 627a9d2:

html_handling: "none" + a rule like / /index.html no longer produces a false "infinite loop" warning at deploy time.
The same rule with HTML handling left at its default is still correctly flagged as an infinite loop, so the real detection isn't weakened.

Both commits are pushed to this PR's branch. Thanks for catching this!

pkg-pr-new · 2026-07-16T12:38:58Z

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14709

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14709

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14709

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14709

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14709

miniflare

npm i https://pkg.pr.new/miniflare@14709

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14709

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14709

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14709

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14709

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14709

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14709

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14709

wrangler

npm i https://pkg.pr.new/wrangler@14709

commit: 16eb284

NuroDev

Can you also update the PR description to reflect the repository template so we have details on tests, docs, etc.

…on PR cloudflare#14709.

…uest on PR cloudflare#14709.

allocsys · 2026-07-17T23:18:15Z

Thanks @NuroDev — addressed all three:

Removed the leftover  comment from .changeset/warm-redirects-deploy-warning.md (4ef9ffe).
Dropped the (#14694) and (#14709 review) issue references from the two test names in assets.test.ts (90ed703).

… appears in the wrangler changelog, per Devin review feedback on PR cloudflare#14709

allocsys · 2026-07-18T09:51:38Z

Good catch — fixed in 175cf65. wrangler now bumped directly in the changeset so this gets a descriptive changelog entry instead of an opaque dependency-bump line.

allocsys · 2026-07-19T13:25:30Z

@NuroDev The PR description now includes the Tests and Documentation sections from the template — could you take another look when you get a chance?

workers-devprod · 2026-07-22T05:05:04Z

Codeowners approval required for this PR:

@cloudflare/deploy-config
@cloudflare/wrangler

Show detailed file reviewers

.changeset/warm-redirects-deploy-warning.md: [@cloudflare/wrangler]
packages/deploy-helpers/src/deploy/helpers/assets.ts: [@cloudflare/wrangler]
packages/workers-shared/utils/configuration/constructConfiguration.ts: [@cloudflare/deploy-config @cloudflare/wrangler]
packages/wrangler/src/tests/deploy/assets.test.ts: [@cloudflare/wrangler]

allocsys added 4 commits July 15, 2026 22:08

Extract formatInvalidRedirectsWarning helper for reuse at deploy time

80536b3

Reuse formatInvalidRedirectsWarning in constructRedirects

9cf08db

Surface _redirects validation warnings at deploy time (fixes cloudfla…

8a35748

…re#14694, option 1)

Add deploy-time tests for _redirects validation warning (cloudflare#1…

9208b00

…4694)

Add changeset for _redirects deploy-time warning (cloudflare#14694)

48e158d

allocsys changed the title ~~Surface _redirects validation warnings at wrangler deploy time (#14694)~~ [wrangler] Surface _redirects validation warnings at deploy time (#14694) Jul 15, 2026

Trigger CI on fork

4423e21

This was referenced Jul 15, 2026

[ci-only] Verify #14709 on fork allocsys/workers-sdk#1

Closed

_redirects: dynamic-rule overflow silently drops rest of file; static/dynamic classification is order-dependent and unsurfaced #14694

Open

allocsys marked this pull request as ready for review July 15, 2026 19:54

allocsys requested a review from workers-devprod as a code owner July 15, 2026 19:54

workers-devprod requested review from a team and NuroDev and removed request for a team July 15, 2026 19:54

This comment was marked as resolved.

Sign in to view

allocsys added 2 commits July 16, 2026 00:26

NuroDev reviewed Jul 16, 2026

View reviewed changes

Comment thread .changeset/warm-redirects-deploy-warning.md Outdated

Comment thread packages/wrangler/src/__tests__/deploy/assets.test.ts Outdated

Comment thread packages/wrangler/src/__tests__/deploy/assets.test.ts Outdated

workers-devprod added this to workers-sdk Jul 16, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Jul 16, 2026

NuroDev requested changes Jul 16, 2026

View reviewed changes

github-project-automation Bot moved this from Untriaged to In Review in workers-sdk Jul 16, 2026

allocsys added 2 commits July 18, 2026 02:48

Remove leftover fork-CI-trigger comment per NuroDev's review request …

4ef9ffe

…on PR cloudflare#14709.

Drop issue/review references from test names per NuroDev's review req…

90ed703

…uest on PR cloudflare#14709.

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into fix/14694-redirects-deploy-warning

c562cd2

This comment was marked as resolved.

Sign in to view

Add wrangler to changeset front-matter so the deploy-time warning fix…

175cf65

… appears in the wrangler changelog, per Devin review feedback on PR cloudflare#14709

Merge branch 'main' into fix/14694-redirects-deploy-warning

16eb284

Uh oh!

Conversation

allocsys commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR solves

Fix

Tests

Documentation

Uh oh!

changeset-bot Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

workers-devprod commented Jul 15, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

allocsys commented Jul 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NuroDev left a comment

Choose a reason for hiding this comment

Uh oh!

allocsys commented Jul 17, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

allocsys commented Jul 18, 2026

Uh oh!

allocsys commented Jul 19, 2026

Uh oh!

workers-devprod commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

allocsys commented Jul 15, 2026 •

edited

Loading

changeset-bot Bot commented Jul 15, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 16, 2026 •

edited

Loading