Add rustls listener certificate resolver support#877
Open
eldryoth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a rustls listener API for passing a custom server certificate resolver.
The existing single-certificate
TlsSettings::intermediate(cert, key)path is unchanged. The newTlsSettings::with_cert_resolver(...)constructor lets applications select downstream certificates during theTLS handshake, for example based on SNI.
The resolver types are re-exported from
pingora-rustls, sopingora-coredoes not need a directrustlsdependency.Testing
Tested with:
cargo fmt --checkcargo check -p pingora-rustlscargo check -p pingora-core --features rustlscargo check -p pingora --features rustlscargo test -p pingora-core --features rustls cert_resolver_settings_build_without_cert_paths