feat(joint-core): Paper.resolveViewClass pass NSView to factory callback#3369
Merged
zbynekstara merged 1 commit intoJun 15, 2026
Merged
Conversation
The `elementView` / `linkView` factory callbacks now receive a second argument `NSView` (the namespace view class, or `null`), and `namespaceViewClass` defaults to `null` instead of `undefined`. Cherry-picked from clientIO#3277 (joint-core portion).
zbynekstara
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of the @joint/core portion of #3277 to
master.Paper.resolveViewClass()— theelementView/linkViewfactory callbacks now receive a second argumentNSView(the namespace view class, ornull), andnamespaceViewClassdefaults tonullinstead ofundefined.The rest of the joint-core changes from #3277 (
CellView.computeNodeBoundingRect,HighlighterViewElement validation, types) already landed onmastervia subsequent commits — this PR closes the remaining gap.Test plan
yarn test-server(joint-core)yarn test-tselementView/linkViewfactory functions can read the newNSViewargument🤖 Generated with Claude Code