Niv update crane + rust-overlay and remove the incorrect app.include entry in the Cargo.toml#107
Merged
OpsBotPrime merged 5 commits intomasterfrom Apr 30, 2026
Merged
Niv update crane + rust-overlay and remove the incorrect app.include entry in the Cargo.toml#107OpsBotPrime merged 5 commits intomasterfrom
app.include entry in the Cargo.toml#107OpsBotPrime merged 5 commits intomasterfrom
Conversation
We want to include exactly those files that the `.gitignore` allows us to include.
Qqwy
changed the title
app.include entry in the Cargo.toml
Qqwy
requested review from
ReinierMaas and
isomorpheme
and removed request for
ReinierMaas
isomorpheme
approved these changes
Apr 30, 2026
Contributor
Author
|
@OpsBotPrime merge and tag |
Contributor
|
Rebased as fe37398, waiting for CI … |
Contributor
|
Stopping integration because the PR changed after approval. |
Contributor
Author
|
@OpsBotPrime merge and tag |
…`app.include` entry in the `Cargo.toml` Approved-by: Qqwy Priority: Normal Auto-deploy: false
Contributor
|
Rebased as 00f6b0a, waiting for CI … |
Contributor
|
CI job 🟡 started. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two changes that make opsqueue nicer to build in larger Nix setups:
includeentry under[app]in theCargo.toml. Turns out I was using it wrong: with no entry it includes the files in the.gitignore(which is what we want), whereas if you write anincludeyourself they are not added on top of the 'normal' Rust files but instead you have to manually supply the exact full set of files you like.craneand therust-overlaywe use, to make sure thatopsqueuestill builds successfully with those newer versions (and we get the stability and efficiency improvements from the newer versions as well)..sqlxfolder entries. As we usesqliteand always have a 'live' sqlite DB available as theopsqueue_example_schema.db, there is no need to run a separatesqlx preparestep for offline building. The sqlite DB can even be used inside sandboxes like the Nix sandbox.This PR is a trimmed down version of #105. It intentionally does not include the extra packaging checks on CI that that PR contains. Rather, properly doing 'CD' by publishing a new version of
opsqueuetocrates.ioand a new version of the Python client to Pypi would have my preference (though this is outside of the scope of this PR).