don't strip results values#1799
Merged
Merged
Conversation
RamilCDISC
approved these changes
Jul 7, 2026
RamilCDISC
left a comment
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
The PR removes unnecessary stripping which was failing the rules that required leading or trialing spaces. The update fixes the behavior to correctly identify the case where stripping is necessary and leaves as it is otherwise. The reduction in error count on the execution of the rules supports the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes unnecessary stripping as seen in CORE-000019
Error count went down here: https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/28888155574
(319->315)