test(integration): add integration tests for NIP-02 contact lists#552
Merged
cameri merged 5 commits intocameri:mainfrom Apr 21, 2026
Merged
Conversation
Collaborator
There was a problem hiding this comment.
Pull request overview
Adds end-to-end Cucumber integration coverage for NIP-02 contact list (kind 3) behavior, ensuring replaceable semantics work correctly through the relay’s WebSocket interface.
Changes:
- Introduces new NIP-02 feature scenarios covering creation, replacement, identical-timestamp tie-breaker, and subscriber behavior.
- Adds step definitions to publish kind 3 events with
ptags and assert query/subscription results (including EOSE). - Includes a Changesets patch entry documenting the test addition.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/integration/features/nip-02/nip-02.feature.ts | Adds Cucumber step definitions for publishing and asserting kind 3 contact list behavior, including replacement and tie-breaker cases. |
| test/integration/features/nip-02/nip-02.feature | Adds NIP-02 Gherkin scenarios for contact list storage/replacement/subscription semantics. |
| .changeset/nip-02-integration-tests.md | Records the test addition as a patch changeset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@cameri, I removed the unused state and updated the variable name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for NIP-02 contact lists (Kind 3), covering replaceable event behavior.
Related Issue
Closes issue #509
Motivation and Context
Currently there were no integration tests for NIP-02 contact list(Kind 3). These tests ensure contact list updates, replacement semantics, and subscription behavior work correctly in practice.
How Has This Been Tested?
test/integration/features/nip-02/Screenshots (if appropriate):
Types of changes
Checklist: