fix: skip Redis auth when credentials are unset with unit test (#541)#545
Open
Justxd22 wants to merge 3 commits intocameri:mainfrom
Open
fix: skip Redis auth when credentials are unset with unit test (#541)#545Justxd22 wants to merge 3 commits intocameri:mainfrom
Justxd22 wants to merge 3 commits intocameri:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Redis cache client configuration so the app does not attempt Redis AUTH when REDIS_PASSWORD is unset (and still respects REDIS_URI when provided), and adds unit tests plus a changeset to cover the expected configuration behavior.
Changes:
- Update
getCacheConfig()to build an unauthenticated Redis URL when credentials are not provided, while keepingREDIS_URIprecedence. - Add unit tests covering unauthenticated config, authenticated config, and
REDIS_URIprecedence. - Add a patch changeset documenting the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/cache/client.ts |
Adjusts Redis client options generation to avoid AUTH when password is unset. |
test/unit/cache/client.spec.ts |
Adds unit coverage for the updated Redis cache config behavior. |
.changeset/thirty-turtles-design.md |
Declares a patch release for the Redis config fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
REDIS_PASSWORDis unsetredis://host:portwhen no credentials are providedREDIS_URIprecedence when presenttest/unit/cache/client.spec.tsfor:REDIS_URI+ no passwordREDIS_URIprecedenceRelated Issue
#541
How Has This Been Tested?
npm run test:unitTypes of changes
Checklist: