Skip to content

close dead connections even if they have active subscriptions #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tharu-jwd wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

close dead connections even if they have active subscriptions #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/adapters/web-socket-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class WebSocketAdapter extends EventEmitter implements IWebSocketAdapter
}

public onHeartbeat(): void {
if (!this.alive && !this.subscriptions.size) {
if (!this.alive) {
logger.error(`web-socket-adapter: pong timeout for client ${this.clientId} (${this.getClientAddress()})`)
this.client.close()
return
Expand Down
6 changes: 3 additions & 3 deletions test/unit/adapters/web-socket-adapter.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,15 @@ describe('WebSocketAdapter', () => {
expect(client.close).to.have.been.calledOnce
})

it('does not close when client is not alive but has subscriptions', () => {
it('closes when client is not alive even if it has active subscriptions', () => {
adapter.onSubscribed('sub-1', [{ kinds: [1] }])

// First heartbeat: sets alive to false, pings
adapter.emit(WebSocketAdapterEvent.Heartbeat)
// Second heartbeat: alive is false, but has subs -> keep alive
// Second heartbeat: alive is still false, has subs -> still close
adapter.emit(WebSocketAdapterEvent.Heartbeat)

expect(client.close).not.to.have.been.called
expect(client.close).to.have.been.called
})
})

Expand Down