feat(pass): support custom store directory via store_dir URI param#116
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
secretspec | c0b9223 | Commit Preview URL Branch Preview URL |
Jun 21 2026, 08:40 PM |
domenkozar
force-pushed
the
pass-store-dir
branch
2 times, most recently
from
d4f140a to
47598fc
Compare
pass has no CLI flag for the store location; PASSWORD_STORE_DIR is the only mechanism. The pass provider now accepts a store_dir query parameter (e.g. pass://?store_dir=/path/to/store), applied as PASSWORD_STORE_DIR scoped to each pass invocation without mutating secretspec's environment. Closes #115 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
domenkozar
force-pushed
the
pass-store-dir
branch
from
47598fc to
c0b9223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Problem
pass(password-store) supports a custom store location only through thePASSWORD_STORE_DIRenvironment variable (man pass), but secretspec gave no way to set it — it always used the hardcoded~/.password-store.Upstream
passhas no CLI flag or config file for this; adirsubcommand was proposed years ago on the mailing list but never landed. The env var is the only supported mechanism.Change
The
passprovider now accepts astore_dirquery parameter:When set,
PASSWORD_STORE_DIRis exported scoped to each spawnedpassprocess — secretspec's own environment is left untouched. The value round-trips throughuri()(it's a path, not a credential, so it's safe in the audit log).Tests
Added unit tests for query parsing (with and without a folder prefix) and URI round-tripping. All pass-provider tests pass; package builds clean.
Docs
docs/src/content/docs/providers/pass.md— documented thestore_dirparam with an example.CHANGELOG.md— entry under the Unreleased "Added" section.🤖 Generated with Claude Code