Skip to content

test(cockpit): promote render examples to e2e#801

Merged
blove merged 1 commit into
mainfrom
blove/cockpit-examples-assessment
Jul 9, 2026
Merged

test(cockpit): promote render examples to e2e#801
blove merged 1 commit into
mainfrom
blove/cockpit-examples-assessment

Conversation

@blove

@blove blove commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Promote all six Render cockpit examples from manual-only checks to target-backed Playwright e2e suites.
  • Add a registry guard so Render examples keep active e2e coverage.
  • Derive the serve-example --all startup count from the capability registry instead of a stale literal.

Test Plan

  • node --test scripts/ci-scope.spec.mjs scripts/cockpit-matrix.spec.mjs scripts/cockpit-ports.spec.mjs
  • npx nx test cockpit -- --run apps/cockpit/scripts/serve-example.spec.ts --reporter=verbose
  • npx nx run-many -t build --configuration=production --projects=cockpit-render-spec-rendering-angular,cockpit-render-element-rendering-angular,cockpit-render-state-management-angular,cockpit-render-registry-angular,cockpit-render-repeat-loops-angular,cockpit-render-computed-functions-angular --skip-nx-cache
  • npx nx run-many -t e2e --projects=cockpit-render-spec-rendering-angular,cockpit-render-element-rendering-angular,cockpit-render-state-management-angular,cockpit-render-registry-angular,cockpit-render-repeat-loops-angular,cockpit-render-computed-functions-angular --parallel=1 --skip-nx-cache

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadplane Ready Ready Preview, Comment Jul 9, 2026 5:09pm

Request Review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove blove merged commit 5d9395b into main Jul 9, 2026
33 checks passed
@blove blove deleted the blove/cockpit-examples-assessment branch July 9, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant