fix(examples-chat): unblock canonical demo prod deploy (bundle budget + Maps key)#776
Conversation
… budget + wire Maps key The App-mode cockpit (@angular/google-maps + @angular/cdk + map/itinerary) pushed the production initial bundle ~80kB over the 1.5MB budget; only the production config enforces budgets, so dev/e2e passed while the 'Canonical demo → Vercel' job failed at build (frontend never deployed). Raise the initial budget to 1.75MB (warn 1.6MB), matching the feature's weight. Also pass GOOGLE_MAPS_API_KEY + GOOGLE_MAPS_MAP_ID to the canonical demo assemble step (mirroring the ag-ui deploy) so inject-env bakes a keyed bundle and the App-mode toggle is enabled in prod.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @blove's task in 54s —— View job PR #776 Review
This is a targeted, two-fix PR. Both changes are correct and well-motivated. A couple of minor observations below.
The One mild concern: the Map ID is now hardcoded in two separate steps. If it ever needs to change, both must be updated together. Consider promoting it to a workflow-level
Both Worth tracking: this is the second budget bump since Verdict: No bugs or security issues found. Changes are correct — good to merge. |
Why
The App-mode itinerary cockpit (#772) merged, but the
Canonical demo → Verceljob failed on main — so the new frontend never deployed (prod still serves the pre-#772 build).Two issues, both fixed here:
Prod bundle budget exceeded.
@angular/google-maps+@angular/cdk/drag-drop+ the map/itinerary surface pushed the production initial bundle ~80 kB over the 1.5 MB budget. Only the production config enforces budgets, so every dev build + e2e passed whileassemble-demo.ts(nx build … --configuration=production) failed. → Raised the initial budget to 1.75 MB (warn 1.6 MB), matching the feature's real weight. (Same class as the earlier cockpit budget bump.)Maps key not wired into the canonical deploy. The
Build and assemble canonical demostep passed noGOOGLE_MAPS_*env, soinject-envbaked a keyless bundle → App-mode toggle disabled in prod. → AddedGOOGLE_MAPS_API_KEY+GOOGLE_MAPS_MAP_ID(mirroring the ag-ui deploy step; same secret + map id).Verified
nx build examples-chat-angular --configuration=production→ generation complete (1.58 MB < 1.75 MB).Backend already deployed on the #772 merge (
Deploy LangGraphsucceeded). Once this lands, the canonical demo redeploys with App mode + the map key enabled.🤖 Generated with Claude Code