Skip to content

fix(cockpit-render): eliminate [object Object] flash for mid-stream value bindings #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 1 commit into from
Jul 7, 2026
Merged

fix(cockpit-render): eliminate [object Object] flash for mid-stream value bindings #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cockpit/render/computed-functions/angular/src/app/computed-functions.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ import { toDisplayText } from '../../../../shared/to-display-text';
}
`,
template: `
@if (label() || value()) {
@if (displayValue()) {
<div class="row">
<span class="row__label">{{ label() }}:</span>
<span class="row__value">{{ value() }}</span>
<span class="row__value">{{ displayValue() }}</span>
</div>
} @else if (loading()) {
<div class="sr-skeleton" style="height: 11px; width: 100%; margin: 3px 0;"></div>
Expand All @@ -49,6 +49,9 @@ import { toDisplayText } from '../../../../shared/to-display-text';
class DemoValueComponent {
readonly label = input('');
readonly value = input<unknown>('');
// Coerce through toDisplayText so an unresolved binding object mid-stream
// (e.g. a partial `$computed` value) renders as the skeleton, not `[object Object]`.
readonly displayValue = computed(() => toDisplayText(this.value()));
readonly childKeys = input<string[]>([]);
readonly spec = input<Spec | null>(null);
readonly bindings = input<Record<string, string>>({});
Expand Down
5 changes: 3 additions & 2 deletions cockpit/render/state-management/angular/src/app/state-management.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ class DemoHeadingComponent {
}
`,
template: `
@if (label() || value()) {
@if (displayValue()) {
<div class="row">
<span class="row__label">{{ label() }}:</span>
<span class="row__value">{{ value() }}</span>
<span class="row__value">{{ displayValue() }}</span>
</div>
} @else if (loading()) {
<div class="sr-skeleton" style="height: 11px; width: 100%; margin: 3px 0;"></div>
Expand All @@ -97,6 +97,7 @@ class DemoHeadingComponent {
class DemoLabelComponent {
readonly label = input('');
readonly value = input('');
readonly displayValue = computed(() => toDisplayText(this.value()));
readonly childKeys = input<string[]>([]);
readonly spec = input<Spec | null>(null);
readonly bindings = input<Record<string, string>>({});
Expand Down
Loading