Add integrated GPS/NTP time sync#504
Conversation
|
Thank you @hjoungjoo for sharing this. This PR is interesting, and I do like the nerdiness of good time sync, but it adds 3,000+ lines of code and does not seem to improve the PiFinder user experience. Aside from setting system time properly for non-networked PiFinders, what other benefits were you aiming for with this code? |
Time synchronization is something I expect will be necessary for the features I have in mind, so I started working on it while adding GPS-related functionality. This was done as a preparatory step because, when implementing guiding functionality for INDI mount control, accurate timing intervals and time calculations are needed in order to estimate the required movement amount and speed. However, even though I have only implemented the basic framework so far, it has already caused changes in too many areas, so I am currently wondering whether I should revert it and start over. |
Summary
Context
This is split out from the larger MF PiFinder compatibility branch as a focused draft PR. Time Sync is off by default; when enabled it can compare GPS and NTP, and it handles poor NTP/network conditions by reporting unavailable or low-quality NTP rather than blocking normal PiFinder operation.
Testing
Notes