Syncing from upstream OCA/storage (18.0)#368
Merged
Merged
Conversation
Add a "Swap Storage Backend" wizard in `storage_file` to move one or more `storage.file` records between backends. Triggered via an `ir.actions.server` bound to `storage.file` list/form views, so it works on multi-selection from the Action menu. The wizard is pre-filled with the current selection's backend as source and refuses any selection spanning multiple backends. The destination domain excludes the source. On apply, `storage.file._swap_backend(new_backend)`: * downloads the binary from the old backend, * uploads to the new one (recomputing `relative_path` from the destination `filename_strategy`), * updates `backend_id` and `relative_path`, * schedules deletion of the old physical file via `cr.postcommit`, so the original is removed only if the transaction commits. On rollback the source file is preserved. Records already on the destination are skipped. The wizard exposes a `_resolve_file_ids(active_model, active_ids)` hook so submodules can map their own records to the underlying `storage.file` ids. `storage_image` and `storage_media` will register server actions on their models that reuse the base wizard.
* drop the postcommit part * make it hookable so that for big batches of files we can rely on queue_job
Allow delegation of big batch of files to queue jobs. [IMP] storage_file_swap_backend_queue: add flag to turn on/off
In case you change the backend directly from form or not.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-18.0/storage-18.0-storage_image Translate-URL: https://translation.odoo-community.org/projects/storage-18-0/storage-18-0-storage_image/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-18.0/storage-18.0-storage_media Translate-URL: https://translation.odoo-community.org/projects/storage-18-0/storage-18-0-storage_media/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-18.0/storage-18.0-storage_file Translate-URL: https://translation.odoo-community.org/projects/storage-18-0/storage-18-0-storage_file/
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #368 +/- ##
==========================================
+ Coverage 86.67% 87.13% +0.46%
==========================================
Files 185 197 +12
Lines 6296 6686 +390
Branches 537 564 +27
==========================================
+ Hits 5457 5826 +369
- Misses 655 667 +12
- Partials 184 193 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot